Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bosh-deploy-with-created-release to build a valid manifest when specifying a release tarball #159

Conversation

geofffranks
Copy link
Contributor

Update bosh_interpolate to pull release version info from the provided tarball to avoid bosh manifest errors

What is this change about?

When providing a release tarball to bosh-deploy-with-created-release, the resultant manifest doesn't include a version directive for the release, and bosh fails to validate the manifest.

Please provide contextual information.

If you're able to see it, this breaks the windows-roofts pipeline, and we're trying to consolidate onto common tasks instead of previously used release-specific tasks that didn't suffer from this issue.

This is a much smaller fix in scope than #139, but if that is deemed preferable, this one is likely not needed.

Please check all that apply for this PR:

  • introduces a new task
  • changes an existing task
  • changes the Dockerfile
  • introduces a breaking change (other users will need to make manual changes when this is released)

Did you update the README as appropriate for this change?

  • YES
  • N/A

How should this change be described in release notes?

Fixes an issue with bosh-deploy-with-created-release where passing a release_tarball_name would result in an invalid BOSH manifest, and deployments would fail.

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

@ctlong ctlong merged commit 9d60cd0 into cloudfoundry:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants