Feat(dockerfile): Upgrade to bullseye #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlong
changed the title
jochenehret
previously approved these changes
Oct 2, 2023
|
Going to wait until tomorrow or the next day to merge in order to give folks time to react to my message in Slack. |
As far as I can tell, copying the bbl repo into `var/repos/bosh-bootloader` is an outdated practice from when we wanted to make the plan-patches and other information available to copy inside the docker container. Searching GitHub, I was unable to find modern examples of code that referenced that location, so I feel good about removing this.
This upgrade to bullseye, which matches Ubuntu Jammy more closely than buster, has been a long time coming. The official Golang docker images finally stopped supporting buster and forced our hand if we wanted to get a later patch of Golang. Had to change some other things in order to get this docker file to build with the new base: - Use the new bosh CLI dependencies (https://bosh.io/docs/cli-v2-install/#ubuntu). - Upgrade to ruby 2.7.7 (what the ruby-full package installs by default).
Some packages are already installed via the base image: - curl - git - wget Some packages I can't determine a reason to keep around: - apt-utils - software-properties-common
Also alphabetically sort the ENVs.
When there's a new version of yq, we should update the Dockerfile to use it.
ctlong
force-pushed
the
feat/dockerfile/bullseye
branch
from
9895646
to
f53902a
Compare
|
Had to rebase to resolve merge conflicts |
jochenehret
approved these changes
Oct 4, 2023
ctlong
added a commit
that referenced
this pull request
Oct 5, 2023
It appears that we used to use `kislyuk/yq` but #167 switched us to `mikefarah/yq` unintentionally. It appears that `--output-format yaml` will work for `mikefarah/yq` the same way that `--yaml-output` worked for `kislyuk/yq`.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Upgrades the cf-d-c-t docker image to have Debian bullseye as the base of the image.
Included some refactors and updates that I think should be relatively minor:
var/repos/bosh-bootloader.Please provide contextual information.
Closes #165.
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None