fix: SYSTEM_DOMAIN incorrectly extracted from toolsmiths-env #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Before this commit, the tasks assume that envs associated with the "toolsmiths-env" input are always under the domain "cf-app.com", which is no longer always the case. - Instead, extract the SYSTEM_DOMAIN from the CF API value provided by the "toolsmiths-env" input. [Fixes #178]
8 tasks
ctlong
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #178]
What is this change about?
Fixes an issue where SYSTEM_DOMAIN is sometimes incorrectly extracted from "toolsmiths-env" input.
Please provide contextual information.
n/a
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How should this change be described in release notes?
Something brief that conveys the change and is written with the component author audience in mind.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.