Skip to content

Commit

Permalink
cf revisions no longer reports EXPERIMENTAL notice
Browse files Browse the repository at this point in the history
  • Loading branch information
chinigo committed Jul 29, 2024
1 parent 04197bf commit f3ba47c
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 10 deletions.
2 changes: 0 additions & 2 deletions command/v7/revision_command.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package v7

import (
"code.cloudfoundry.org/cli/command"
"code.cloudfoundry.org/cli/command/flag"
)

Expand All @@ -14,7 +13,6 @@ type RevisionCommand struct {
}

func (cmd RevisionCommand) Execute(_ []string) error {
cmd.UI.DisplayWarning(command.ExperimentalWarning)
cmd.UI.DisplayNewline()
return nil
}
4 changes: 2 additions & 2 deletions command/v7/revision_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var _ = Describe("revision Command", func() {
Expect(cmd.Execute(nil)).To(Succeed())
})

It("displays the experimental warning", func() {
Expect(testUI.Err).To(Say("This command is in EXPERIMENTAL stage and may change without notice"))
It("no longer displays the experimental warning", func() {
Expect(testUI.Err).NotTo(Say("This command is in EXPERIMENTAL stage and may change without notice"))
})
})
2 changes: 0 additions & 2 deletions command/v7/revisions_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"strconv"

"code.cloudfoundry.org/cli/actor/v7action"
"code.cloudfoundry.org/cli/command"
"code.cloudfoundry.org/cli/command/flag"
"code.cloudfoundry.org/cli/resources"
"code.cloudfoundry.org/cli/util/ui"
Expand All @@ -26,7 +25,6 @@ type RevisionsCommand struct {
}

func (cmd RevisionsCommand) Execute(_ []string) error {
cmd.UI.DisplayWarning(command.ExperimentalWarning)
cmd.UI.DisplayNewline()

err := cmd.SharedActor.CheckTarget(true, true)
Expand Down
4 changes: 2 additions & 2 deletions command/v7/revisions_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ var _ = Describe("revisions Command", func() {
executeErr = cmd.Execute(nil)
})

It("displays the experimental warning", func() {
Expect(testUI.Err).To(Say("This command is in EXPERIMENTAL stage and may change without notice"))
It("no longer displays the experimental warning", func() {
Expect(testUI.Err).NotTo(Say("This command is in EXPERIMENTAL stage and may change without notice"))
})

When("checking target fails", func() {
Expand Down
2 changes: 1 addition & 1 deletion integration/v7/isolated/revision_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var _ = Describe("revision command", func() {
It("appears in cf help -a", func() {
session := helpers.CF("help", "-a")
Eventually(session).Should(Exit(0))
Expect(session).To(HaveCommandInCategoryWithDescription("revision", "EXPERIMENTAL COMMANDS", "Show details for a specific app revision"))
Expect(session).NotTo(HaveCommandInCategoryWithDescription("revision", "EXPERIMENTAL COMMANDS", "Show details for a specific app revision"))
})

It("Displays revision command usage to output", func() {
Expand Down
2 changes: 1 addition & 1 deletion integration/v7/isolated/revisions_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var _ = Describe("revisions command", func() {
It("appears in cf help -a", func() {
session := helpers.CF("help", "-a")
Eventually(session).Should(Exit(0))
Expect(session).To(HaveCommandInCategoryWithDescription("revisions", "EXPERIMENTAL COMMANDS", "List revisions of an app"))
Expect(session).NotTo(HaveCommandInCategoryWithDescription("revisions", "EXPERIMENTAL COMMANDS", "List revisions of an app"))
})

It("Displays command usage to output", func() {
Expand Down

0 comments on commit f3ba47c

Please sign in to comment.