Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf revisions no longer reports EXPERIMENTAL notice [main] #3062

Conversation

chinigo
Copy link
Contributor

@chinigo chinigo commented Jul 29, 2024

Description of the Change

This commit changes the cf revision and cf revisions commands to no longer print a notice that the command is experimental.

Why Is This PR Valuable?

The cf revision and cf revisions commands were introduced over 4 years ago and are no longer experimental.

Applicable Issues

n/a

How Urgent Is The Change?

Not urgent.

Other Relevant Parties

None

Related PRs

@chinigo chinigo marked this pull request as ready for review July 29, 2024 18:42
@chinigo chinigo changed the title cf revisions no longer reports EXPERIMENTAL notice [main] cf revisions no longer reports EXPERIMENTAL notice [main] Jul 29, 2024
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b force-pushed the 187923330-no-longer-mark-revisions-experimental-main branch from f6db66d to 4d9afeb Compare August 1, 2024 20:57
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the test was there to ensure that the message was present I do not think these tests make sense anymore.
If you come back to the code and see this test, it is strange 😄

@chinigo chinigo force-pushed the 187923330-no-longer-mark-revisions-experimental-main branch from 4d9afeb to 03fd9b0 Compare August 5, 2024 16:58
@chinigo
Copy link
Contributor Author

chinigo commented Aug 5, 2024

  • Negative test assertions removed (including one whole file that contained nothing but).
  • Moved the revisions and revision command into the APPS section of the cf help output.

@chinigo chinigo force-pushed the 187923330-no-longer-mark-revisions-experimental-main branch from 03fd9b0 to 411bfc6 Compare August 5, 2024 21:06
@chinigo chinigo force-pushed the 187923330-no-longer-mark-revisions-experimental-main branch from 411bfc6 to 6149404 Compare August 13, 2024 15:35
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit a5ed00b into cloudfoundry:main Aug 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants