Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cf revisions no longer reports EXPERIMENTAL notice [main] #3062

Merged
merged 6 commits into from
Aug 13, 2024
Merged

cf revisions no longer reports EXPERIMENTAL notice [main] #3062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef92f7c
`cf revisions` no longer reports EXPERIMENTAL notice
chinigo Jul 29, 2024
63f973c
Move `revision` and `revisions` commands into APPS section of help
chinigo Aug 5, 2024
608e848
Remove negative assertions for revision commands' experimental status
chinigo Aug 5, 2024
bd53c85
Restore "revision" command to experimental status
chinigo Aug 13, 2024
6149404
`cf rollback` no longer reports EXPERIMENTAL status
chinigo Aug 13, 2024
73d7d08
Remove superfluous newline
chinigo Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion command/common/internal/help_all_display.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ var HelpCategoryList = []HelpCategory{
{"start", "stop", "restart", "stage-package", "restage", "restart-app-instance"},
{"run-task", "tasks", "terminate-task"},
{"packages", "create-package"},
{"revisions", "rollback"},
{"droplets", "set-droplet", "download-droplet"},
{"events", "logs"},
{"env", "set-env", "unset-env"},
Expand Down Expand Up @@ -172,7 +173,7 @@ var ExperimentalHelpCategoryList = []HelpCategory{
{
CategoryName: "EXPERIMENTAL COMMANDS:",
CommandList: [][]string{
{"revisions", "revision", "rollback"},
Samze marked this conversation as resolved.
Show resolved Hide resolved
{"revision"},
},
},
}
4 changes: 0 additions & 4 deletions command/v7/revisions_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"strconv"

"code.cloudfoundry.org/cli/actor/v7action"
"code.cloudfoundry.org/cli/command"
"code.cloudfoundry.org/cli/command/flag"
"code.cloudfoundry.org/cli/resources"
"code.cloudfoundry.org/cli/util/ui"
Expand All @@ -26,9 +25,6 @@ type RevisionsCommand struct {
}

func (cmd RevisionsCommand) Execute(_ []string) error {
cmd.UI.DisplayWarning(command.ExperimentalWarning)
cmd.UI.DisplayNewline()

err := cmd.SharedActor.CheckTarget(true, true)
if err != nil {
return err
Expand Down
4 changes: 0 additions & 4 deletions command/v7/revisions_command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ var _ = Describe("revisions Command", func() {
executeErr = cmd.Execute(nil)
})

It("displays the experimental warning", func() {
Expect(testUI.Err).To(Say("This command is in EXPERIMENTAL stage and may change without notice"))
})

When("checking target fails", func() {
BeforeEach(func() {
fakeSharedActor.CheckTargetReturns(actionerror.NotLoggedInError{BinaryName: binaryName})
Expand Down
3 changes: 0 additions & 3 deletions command/v7/rollback_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ func (cmd *RollbackCommand) Setup(config command.Config, ui command.UI) error {
}

func (cmd RollbackCommand) Execute(args []string) error {
cmd.UI.DisplayWarning(command.ExperimentalWarning)
cmd.UI.DisplayNewline()

targetRevision := int(cmd.Version.Value)
err := cmd.SharedActor.CheckTarget(true, true)
if err != nil {
Expand Down
4 changes: 0 additions & 4 deletions command/v7/rollback_command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ var _ = Describe("rollback Command", func() {
executeErr = cmd.Execute(nil)
})

It("displays the experimental warning", func() {
Expect(testUI.Err).To(Say("This command is in EXPERIMENTAL stage and may change without notice"))
})

When("checking target fails", func() {
BeforeEach(func() {
fakeSharedActor.CheckTargetReturns(actionerror.NoOrganizationTargetedError{BinaryName: binaryName})
Expand Down
2 changes: 1 addition & 1 deletion integration/v7/isolated/revisions_command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var _ = Describe("revisions command", func() {
It("appears in cf help -a", func() {
session := helpers.CF("help", "-a")
Eventually(session).Should(Exit(0))
Expect(session).To(HaveCommandInCategoryWithDescription("revisions", "EXPERIMENTAL COMMANDS", "List revisions of an app"))
Expect(session).To(HaveCommandInCategoryWithDescription("revisions", "APPS", "List revisions of an app"))
})

It("Displays command usage to output", func() {
Expand Down
2 changes: 1 addition & 1 deletion integration/v7/isolated/rollback_command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ var _ = Describe("rollback command", func() {
It("appears in cf help -a", func() {
session := helpers.CF("help", "-a")
Eventually(session).Should(Exit(0))
Expect(session).To(HaveCommandInCategoryWithDescription("rollback", "EXPERIMENTAL COMMANDS", "Rollback to the specified revision of an app"))
Expect(session).To(HaveCommandInCategoryWithDescription("rollback", "APPS", "Rollback to the specified revision of an app"))
})

It("Displays rollback command usage to output", func() {
Expand Down
Loading