Ruby 3.3 support

[moleske]

Thanks for submitting an issue to cloud_controller_ng. We are always trying to improve! To help us, please fill out the following template.

Issue

Ruby 3.3 requires some changes based on quick tests with ruby-3.3.0-rc

Context

Two issues (so far) related to Regexp.new expecting 2 arguments but getting three

• rfc822 - (used in cloud controller in these two places only) https://github.com/mspanc/rfc822/blob/master/lib/rfc822.rb#L16
• cookiejar - (which is a dependency of em-http-request) Suppress deprecation warning for Regexp.new with 3rd argument dwaite/cookiejar#52

There may be more but this is what I hit so far

Steps to Reproduce

run bundle exec rake while using ruby 3.3

Expected result

it works

Current result

it's sad

Possible Fix

see context

name of issue screenshot

no

[moleske]

I think those are the only issues for bundle exec rake. Since there's no bosh ruby package yet I didn't bother trying to hack something for testing with CATS/SITS/BARAS

The terrible hacks I did to test that we definitely shouldn't do are

• manually edit the cookiejar gem at gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb
• copy and paste the chunk of code from the rfc822 into our code

see this aptly named branch for what I did (and let's not do what I did on the branch, or at least do it not so quick and dirty)
https://github.com/cloudfoundry/cloud_controller_ng/tree/terrible-things-to-get-to-ruby-3.3