Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudpickle could extend pickle5 #179

Closed
pitrou opened this issue Jun 26, 2018 · 6 comments · Fixed by #370
Closed

cloudpickle could extend pickle5 #179

pitrou opened this issue Jun 26, 2018 · 6 comments · Fixed by #370

Comments

@pitrou
Copy link
Member

pitrou commented Jun 26, 2018

I'm not sure how adventurous people here want to get, but cloudpickle could extend pickle5 instead of the built-in pickle module, at least when available.

@ogrisel
@jakirkham
Copy link
Member

Sounds like a great idea to me. 👍

cc @mrocklin

@ogrisel
Copy link
Contributor

ogrisel commented Oct 1, 2018

+1 :)

@jakirkham
Copy link
Member

I'm curious if anyone has tried this. Some of the discussion in PR ( #253 ) suggests it might have been explored. Also looks like PR ( #308 ) added the missing keyword argument.

This was referenced May 7, 2020
Merged
Closed
Closed
@jakirkham
Copy link
Member

Rough attempt of this in PR ( #364 ). Probably still needs a bit more work.

@jakirkham jakirkham mentioned this issue May 29, 2020
Merged
@jakirkham
Copy link
Member

Rough attempt of this in PR ( #364 ). Probably still needs a bit more work.

This has been replaced by PR ( #370 ). Could use some reviews if anyone has time to look 🙂

@jakirkham
Copy link
Member

Thanks all! 😄

This is now included in 1.5.0 recently released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ogrisel @pitrou @jakirkham