Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate spatialmath.py #113

Open
cmower opened this issue Mar 14, 2023 · 1 comment
Open

Deprecate spatialmath.py #113

cmower opened this issue Mar 14, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request future Plans for the future. help wanted Happy to accept pull requests

Comments

@cmower
Copy link
Owner

cmower commented Mar 14, 2023

Let's consider removing spatialmath.py and replace it's functionality by using spatial-casadi.

@cmower cmower added the future Plans for the future. label May 8, 2023
@cmower cmower self-assigned this May 13, 2023
@cmower cmower changed the title Consider deprecating spatialmath.py Deprecate spatialmath.py Jun 6, 2023
@cmower cmower added the help wanted Happy to accept pull requests label Aug 11, 2023
@cmower
Copy link
Owner Author

cmower commented Aug 11, 2023

Some notes

  • When extracting rpy from the URDF, the way to convert this to a spatial_casadi.Rotation is to use spatial_casadi.Rotation.from_euler("XYZ", rpy)
  • Many unit tests need to be deprecated and updated
  • Remember to add spatial-casadi to setup.py as a dependency
  • Need to consider how to handle Jacobians. It would be inconsistent for get methods referring to Jacobian arrays to return either casadi.DM, casadi.SX, numpy.ndarray. Better to return a Jacobian object (this would need implementing). This could be designed similar to spatial casadi and have some sort of structure as follows
class Jacobian:

    def linear(self):
        pass # returns linear part of jacobain

    def angular(self, type):
        pass # returns angular part of jacobian (given the type)
      
    def geometric(self):
        pass # returns geometric jacobian

    def analytic(self, seq):
        pass # returns analytic jacobian with given sequence for angular part    

@cmower cmower added the enhancement New feature or request label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Plans for the future. help wanted Happy to accept pull requests
Projects
None yet
Development

No branches or pull requests

1 participant