New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential erf approximation bug in point_outlier.h #221

Open

adelpit opened this issue May 30, 2023 · 0 comments

adelpit commented May 30, 2023 •

edited

Loading

Inside the LoOP filter in point_outlier.h, there is a step that approximates the error function (erf)

erf(x) ~ 1 - 1 / dem

where dem = 1 + a1*x + a2*x^2 + a3*x^3 + a4*x^4

However, this seems to be missing an exponent to the 4th power. See the actual approximation to erf should be:

erf(x) ~ 1 - 1 / dem^4

Is this a bug or an intentional difference?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment