Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n/a scores discussion #1540

Open
7 tasks
ihsaan-ullah opened this issue Jul 18, 2024 · 2 comments
Open
7 tasks

n/a scores discussion #1540

ihsaan-ullah opened this issue Jul 18, 2024 · 2 comments
Labels
Bug Discussion Needs to be discussed before we can come up with specifications and begin the issue P1 High priority, but NOT a current blocker

Comments

@ihsaan-ullah
Copy link
Collaborator

ihsaan-ullah commented Jul 18, 2024

We have several issues that report n/a scores on the leaderboard. n/a is a replacement of score shown for a task not found. The problem is that the scores and tasks are separate and are sent to the frontend where they are matched and then scores are shown for a task or several tasks. This opens room for inconsistencies.

I propose to make the leaderboard on the backend and just send it to be displayed without any extraction or computation. This way we will never have n/a scores.

Issues reporting n/a scores:

@ihsaan-ullah ihsaan-ullah added the Discussion Needs to be discussed before we can come up with specifications and begin the issue label Jul 18, 2024
@Didayolo
Copy link
Collaborator

How much work does this change represent?

@ihsaan-ullah
Copy link
Collaborator Author

I guess quite amount of work. It may also disclose some hidden bugs. But it seems important because this problem is hanging there from a long time.

This is just the start of the discussion. We may want to discuss in detail how things are done now in the code and what we want to do change there and discuss the benefits.

One thing I insist on is to move the logic to the backend. Frontend should not have logic (unless really needed). This simplifies the front-end and less buggy and makes the backend strong. Additionally, backend should be written in a clear way so that in this effort we don't make it buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Discussion Needs to be discussed before we can come up with specifications and begin the issue P1 High priority, but NOT a current blocker
Projects
None yet
Development

No branches or pull requests

2 participants