Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthnContextClassRef - Unspecified value using weird constant. #59

Open
thomasjosif opened this issue Apr 27, 2021 · 1 comment · May be fixed by #63
Open

AuthnContextClassRef - Unspecified value using weird constant. #59

thomasjosif opened this issue Apr 27, 2021 · 1 comment · May be fixed by #63

Comments

@thomasjosif
Copy link

Hi,

I was integrating this idp with a service that requires me to have an AuthnContextClassRef, it by default accepts:
urn:oasis:names:tc:SAML:2.0:ac:classes:unspecified which seems pretty standard.

But in this package for some reason the default value found here

->setAuthnContextClassRef(SamlConstants::NAME_ID_FORMAT_UNSPECIFIED)

is:
urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified

Is there any rhyme or reason behind this or would it be possible for me to make a PR to change that line to use this constant found here?
https://github.com/lightSAML/lightSAML/blob/b5e37b001c68da82bea8b2ca30230598368c51d1/src/LightSaml/SamlConstants.php#L69

Thanks!

@upwebdesign
Copy link
Contributor

@thomasjosif if you would like to make a PR, please do. I will review as soon as I am able!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants