Merge pull request #9117 from kenjis/add-directives-to-phpini-check

feat: add directives to `phpini:check` command
codeigniter4 · Aug 19, 2024 · 510bf8b · 510bf8b
2 parents 32a11f9 + aa6df4e
commit 510bf8b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/system/Commands/Utilities/PhpIniCheck.php b/system/Commands/Utilities/PhpIniCheck.php
@@ -41,7 +41,7 @@ final class PhpIniCheck extends BaseCommand
      *
      * @var string
      */
-    protected $description = 'Check your php.ini values.';
+    protected $description = 'Check your php.ini values in production environment.';
 
     /**
      * The Command's usage

diff --git a/system/Security/CheckPhpIni.php b/system/Security/CheckPhpIni.php
@@ -124,9 +124,11 @@ public static function checkIni(): array
             'log_errors'              => [],
             'error_log'               => [],
             'default_charset'         => ['recommended' => 'UTF-8'],
+            'max_execution_time'      => ['remark' => 'The default is 30.'],
             'memory_limit'            => ['remark' => '> post_max_size'],
             'post_max_size'           => ['remark' => '> upload_max_filesize'],
             'upload_max_filesize'     => ['remark' => '< post_max_size'],
+            'max_input_vars'          => ['remark' => 'The default is 1000.'],
             'request_order'           => ['recommended' => 'GP'],
             'variables_order'         => ['recommended' => 'GPCS'],
             'date.timezone'           => ['recommended' => 'UTC'],
@@ -135,6 +137,7 @@ public static function checkIni(): array
             'opcache.enable_cli'      => [],
             'opcache.jit'             => [],
             'opcache.jit_buffer_size' => [],
+            'zend.assertions'         => ['recommended' => '-1'],
         ];
 
         $output = [];