fix: updateBatch() may generate invalid SQL string

codeigniter4 · Aug 7, 2023 · 6b05c90 · 6b05c90
1 parent 2238bf1
commit 6b05c90
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -979,7 +979,9 @@ public function updateBatch(?array $set = null, ?string $index = null, int $batc
                 // properties representing the collection elements, we need to grab
                 // them as an array.
                 if (is_object($row) && ! $row instanceof stdClass) {
-                    $row = $this->objectToArray($row, true, true);
+                    // For updates the index field is needed even if it is not changed.
+                    // So set $onlyChanged to false.
+                    $row = $this->objectToArray($row, false, true);
                 }
 
                 // If it's still a stdClass, go ahead and convert to