Merge pull request #7766 from ping-yee/230802-phpstan-event

Dev: remove the `event` ignore errors in phpstan-baseline.php
codeigniter4 · Aug 3, 2023 · 89d249a · 89d249a
2 parents b3fe701 + 35b1aa9
commit 89d249a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 25 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -901,41 +901,16 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Entity/Entity.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Events\\\\Events\\:\\:initialize\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Events/Events.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Events\\\\Events\\:\\:on\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Events/Events.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method CodeIgniter\\\\Events\\\\Events\\:\\:on\\(\\) has parameter \\$callback with no signature specified for callable\\.$#',
 	'count' => 1,
 	'path' => __DIR__ . '/system/Events/Events.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Events\\\\Events\\:\\:removeAllListeners\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Events/Events.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method CodeIgniter\\\\Events\\\\Events\\:\\:removeListener\\(\\) has parameter \\$listener with no signature specified for callable\\.$#',
 	'count' => 1,
 	'path' => __DIR__ . '/system/Events/Events.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Events\\\\Events\\:\\:setFiles\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Events/Events.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Events\\\\Events\\:\\:simulate\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Events/Events.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method CodeIgniter\\\\Exceptions\\\\CastException\\:\\:forInvalidJsonFormatException\\(\\) has no return type specified\\.$#',
 	'count' => 1,

diff --git a/system/Events/Events.php b/system/Events/Events.php
@@ -63,6 +63,8 @@ class Events
 
     /**
      * Ensures that we have a events file ready.
+     *
+     * @return void
      */
     public static function initialize()
     {
@@ -108,6 +110,8 @@ public static function initialize()
      * @param string   $eventName
      * @param callable $callback
      * @param int      $priority
+     *
+     * @return void
      */
     public static function on($eventName, $callback, $priority = self::PRIORITY_NORMAL)
     {
@@ -222,6 +226,8 @@ public static function removeListener($eventName, callable $listener): bool
      * removed, otherwise all listeners for all events are removed.
      *
      * @param string|null $eventName
+     *
+     * @return void
      */
     public static function removeAllListeners($eventName = null)
     {
@@ -234,6 +240,8 @@ public static function removeAllListeners($eventName = null)
 
     /**
      * Sets the path to the file that routes are read from.
+     *
+     * @return void
      */
     public static function setFiles(array $files)
     {
@@ -254,6 +262,8 @@ public static function getFiles()
      * Turns simulation on or off. When on, events will not be triggered,
      * simply logged. Useful during testing when you don't actually want
      * the tests to run.
+     *
+     * @return void
      */
     public static function simulate(bool $choice = true)
     {