refactor: prevent using empty() on CURLRequest
#9195
+10
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -469,7 +469,7 @@ protected function applyMethod(string $method, array $curlOptions): array | |||
| */ | |||
| protected function applyBody(array $curlOptions = []): array | |||
| { | |||
| if (! empty($this->body)) { | |||
| if ($this->body !== '' && $this->body !== null) { | |||
There was a problem hiding this comment.
can we just cast to string then check against empty string?
system/HTTP/CURLRequest.php
Outdated
| @@ -518,18 +518,18 @@ protected function setResponseHeaders(array $headers = []) | |||
| protected function setCURLOptions(array $curlOptions = [], array $config = []) | |||
| { | |||
| // Auth Headers | |||
| if (! empty($config['auth'])) { | |||
| if (array_key_exists('auth', $config) && $config['auth']) { | |||
There was a problem hiding this comment.
for the right side of && can we be specific what we are checking against?
| $curlOptions[CURLOPT_HTTPAUTH] = CURLAUTH_DIGEST; | ||
| } else { | ||
| $curlOptions[CURLOPT_HTTPAUTH] = CURLAUTH_BASIC; | ||
| } | ||
| } | ||
|
|
||
| // Certificate | ||
| if (! empty($config['cert'])) { | ||
| if (array_key_exists('cert', $config) && $config['cert']) { |
There was a problem hiding this comment.
for right side of && we can check against empty array or empty string?
There was a problem hiding this comment.
:532 Result of || is always true.
🪪 booleanOr.alwaysTrue
:532 Strict comparison using !== between array{} and '' will always evaluate to true.
🪪 notIdentical.alwaysTrue
| @@ -575,7 +575,7 @@ protected function setCURLOptions(array $curlOptions = [], array $config = []) | |||
| } | |||
|
|
|||
| // Decode Content | |||
| if (! empty($config['decode_content'])) { | |||
| if (array_key_exists('decode_content', $config) && $config['decode_content']) { | |||
There was a problem hiding this comment.
for right side, pls be more specific what we are checking against
| @@ -650,7 +650,7 @@ protected function setCURLOptions(array $curlOptions = [], array $config = []) | |||
| } | |||
|
|
|||
| // version | |||
| if (! empty($config['version'])) { | |||
| if (array_key_exists('version', $config) && $config['version']) { | |||
There was a problem hiding this comment.
right side change to is_string and !== ''?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decrease PHPStan baseline.
Checklist: