fix: Allow lists on FeatureTestTrait#post $params #9204
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can reproduce the bug by deleting |
michalsn
added
the
bug
|
Thank you for your first contribution! Can you also add an entry to the changelog, under the section "Bugs Fixed"? |
|
Done |
3ynm
force-pushed
the
develop
branch
2 times, most recently
from
d58a30a
to
e40ef7e
Compare
michalsn
requested changes
Sep 27, 2024
Comment on lines
+33
to
+34
| **FeatureTestTrait:** Allows `#call` and `#post` to process JSON lists. It failed because `RequestTrait#fetchGlobal` expected the second parameter ($index) to be an associative array. | ||
|
|
There was a problem hiding this comment.
The bug was in the RequestTrait class.
Suggested change
| **FeatureTestTrait:** Allows `#call` and `#post` to process JSON lists. It failed because `RequestTrait#fetchGlobal` expected the second parameter ($index) to be an associative array. | |
| **RequestTrait:** A bug where sending a JSON list in a request caused an error. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description**
Fixes a bug that doesn't allow to send lists in JSON format in
FeatureTestTrait#postor#call('POST',.... This because it expected params to always be an associative array.Checklist: