Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails (sometimes) with error in file 'reportcontrol.test.ts' #206

Open
dlabordus opened this issue Nov 16, 2022 · 2 comments
Open
Labels
bug Something isn't working stale

Comments

@dlabordus
Copy link

Describe the bug
Sometimes the build fails with the following error:

test/unit/wizards/reportcontrol.test.ts:

 ❌ Wizards for SCL ReportControl element > define an edit wizard that > for complete ReportControl element > rejects intgPd attribute starting with not being a unsigned int
      Error: Property failed after 81 tests
      { seed: 486084177, path: "80:2", endOnFailure: true }
      Counterexample: ["-0"]
      Shrunk 1 time(s)
      Got error: AssertionError: expected true to be false
      
      Stack trace: AssertionError: expected true to be false
          at http://localhost:8000/test/unit/wizards/reportcontrol.test.ts?wtr-session-id=KMsQCXsTcWqxuzqw_Rjlw:89:46
          at async AsyncProperty.run (http://localhost:8000/node_modules/fast-check/lib/esm/check/property/AsyncProperty.generic.js:38:28)
          at async asyncRunIt (http://localhost:8000/node_modules/fast-check/lib/esm/check/runner/Runner.js:21:21)
          at async qy.<anonymous> (http://localhost:8000/test/unit/wizards/reportcontrol.test.ts?wtr-session-id=KMsQCXsTcWqxuzqw_Rjlw:86:9)
      
      Hint: Enable verbose mode in order to have the list of all failing values encountered during the run
        at test/unit/wizards/reportcontrol.test.ts:147:48
        at async AsyncProperty.run (node_modules/fast-check/lib/esm/check/property/AsyncProperty.generic.js:38:28)
        at async asyncRunIt (node_modules/fast-check/lib/esm/check/runner/Runner.js:21:21)
        at async qy.<anonymous> (test/unit/wizards/reportcontrol.test.ts:143:8)
        Hint: Enable verbose mode in order to have the list of all failing values encountered during the run
        at asyncThrowIfFailed (node_modules/fast-check/lib/esm/check/runner/utils/RunDetailsFormatter.js:128:11)

Restarting the job will most of the time be successful.

Expected behavior
Build should not fai;l :-)

Additional context
This probably needs to be fixed in the upstream OpenSCD.

@dlabordus dlabordus added the bug Something isn't working label Nov 16, 2022
@dlabordus
Copy link
Author

Also have a lot of these errors

❌ open-scd > looks like its snapshot
      AssertionError: Snapshot open-scd looks like its snapshot does not match the saved snapshot on disk
      + expected - actual
      
         <mwc-list
           id="content"
           wrapfocus=""
         >
      -    <abbr title="Error communicating with CoMPAS Ecosystem">
      -      <mwc-list-item
      -        aria-disabled="false"
      -        class="error"
      -        graphic="icon"
      -        mwc-list-item=""
      -        tabindex="-1"
      -        twoline=""
      -      >
      -        <span>
      -          <tt>
      -            11/24/2022, 11:53:50 AM
      -          </tt>
      -          Error communicating with CoMPAS Ecosystem
      -        </span>
      -        <span slot="secondary">
      -          NotFoundError: Not Found (404)
      -        </span>
      -        <mwc-icon
      -          slot="graphic"
      -          style="--mdc-theme-text-icon-on-background:var(--red)"
      -        >
      -          report
      -        </mwc-icon>
      -      </mwc-list-item>
      -    </abbr>
      -    <abbr title="Error communicating with CoMPAS Ecosystem">
      -      <mwc-list-item
      -        aria-disabled="false"
      -        class="error"
      -        graphic="icon"
      -        mwc-list-item=""
      -        tabindex="-1"
      -        twoline=""
      -      >
      -        <span>
      -          <tt>
      -            11/24/2022, 11:53:50 AM
      -          </tt>
      -          Error communicating with CoMPAS Ecosystem
      -        </span>
      -        <span slot="secondary">
      -          NotFoundError: Not Found ([404](https://github.com/com-pas/compas-open-scd/actions/runs/3540145116/jobs/5943145278#step:7:405))
      -        </span>
      -        <mwc-icon
      -          slot="graphic"
      -          style="--mdc-theme-text-icon-on-background:var(--red)"
      -        >
      -          report
      -        </mwc-icon>
      -      </mwc-list-item>
      -    </abbr>
      +    <mwc-list-item
      +      aria-disabled="true"
      +      disabled=""
      +      graphic="icon"
      +      mwc-list-item=""
      +      tabindex="0"
      +    >
      +      <span>
      +        Edits, errors, and other notifications will show up here.
      +      </span>
      +      <mwc-icon slot="graphic">
      +        info
      +      </mwc-icon>
      +    </mwc-list-item>
         </mwc-list>
         <mwc-button
           disabled=""
           icon="undo"
         </mwc-icon-button>
       </mwc-snackbar>
       <mwc-snackbar
         id="error"
      -  labeltext="Error communicating with CoMPAS Ecosystem"
      -  open=""
      +  labeltext="No errors"
         timeoutms="10000"
       >
         <mwc-button
           icon="history"

@github-actions
Copy link

Hello there,

Thank you for opening this issue! We appreciate your interest in our project.
However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.

If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better.
Feel free to continue the conversation here.

If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.

Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve.
Thank you for being part of this journey!

@github-actions github-actions bot added the stale label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

1 participant