ci: Build Docker image during test #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current test relies on a Docker image that's built previously, meaning that if the dependencies change we need to build and push that image manually beforehand. This should hopefully improve the process. Signed-off-by: Thane Thomson <connect@thanethomson.com>
Since this image is now being built upon every Test workflow run, we no longer need to additionally build the image on every PR. Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
|
This should help toward #42. |
lasarojc
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current test relies on a Docker image that's built previously, meaning that if the dependencies change we need to build and push that image manually beforehand.
This should hopefully improve the process by instead building the image during the test process, and using that same image for the tests.
It takes long to build the image (10mins), but I imagine that changes like #42 that change database dependencies are really the only reason for us to continue cutting new releases here.