Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latency increase from 1.10 to 1.11 #274

Open
jakobnissen opened this issue Apr 23, 2024 · 6 comments
Open

Latency increase from 1.10 to 1.11 #274

jakobnissen opened this issue Apr 23, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@jakobnissen
Copy link
Contributor

A small CLI tool I created had its latency go from 0.9 s to 2.7 s when going from Julia 1.10 to 1.11. This might be due to REPL and Pkg being moved out of the system image.

In total, Comonicon brings in 40 transitive dependencies. That seems like a lot. Perhaps an approach to reducing Comonicon's latency is to cut dependencies.

@jakobnissen jakobnissen added the bug Something isn't working label Apr 23, 2024
@Roger-luo
Copy link
Collaborator

This is exactly why I proposed this JuliaLang/julia#48819. This is not sustainable if we require downstream developers to change their implementation every time something is changed upstream.

I'm not sure which downstream dependency has latency changes. Comonicon only has 4 direct non-stdlib dependencies, which is why it doesn't matter that much before 1.11. Again if we require downstream packages with only 4 direct dependencies (now perhaps 5 or 6) to update its code, this is a very big red flag in maintaining the ecosystem. I'd rather just switch to rust.

@Roger-luo
Copy link
Collaborator

OK, so it turns out the current solution should be moving the Docs.doc query implementation out of the REPL package.

@jakobnissen
Copy link
Contributor Author

If JuliaLang/julia#54499 indeed lands and is backported to 1.11, then REPL might not be needed, and can be removed from the dependencies (REPL will be available in versions of Julia before 1.11). Then this issue would be solved.

@IanButterworth
Copy link

I've been trying to investigate this from JuliaLang/julia#55171 but cannot build the reproducer. Can anyone help over there?

@IanButterworth
Copy link

Bump. I'm interested in investigating this if someone can help

@Roger-luo
Copy link
Collaborator

Sorry I got Covid after JuliaCon. I replied in that issue, please let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants