-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #11449 from Toflar/fix/poolbuilder-replace-should-…
…be-optional Optimize PoolBuilder to not load replaced targets if not required
- Loading branch information
Showing
5 changed files
with
142 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...st/DependencyResolver/Fixtures/poolbuilder/load-replaced-package-if-replacer-dropped.test
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
--TEST-- | ||
Ensure that a package gets loaded which was previously skipped due to replacement | ||
|
||
--REQUEST-- | ||
{ | ||
"require": { | ||
"root/dep": "*", | ||
"root/no-update": "*" | ||
}, | ||
"locked": [ | ||
{"name": "root/dep", "version": "1.1.0", "require": {"replacer/pkg": "1.*"}}, | ||
{"name": "replacer/pkg", "version": "1.0.0", "replace": {"replaced/pkg": "1.0.0"}}, | ||
{"name": "root/no-update", "version": "1.0.0", "require": {"replaced/pkg": "1.0.0"}} | ||
], | ||
"allowList": [ | ||
"root/dep" | ||
], | ||
"allowTransitiveDepsNoRootRequire": true | ||
} | ||
|
||
--FIXED-- | ||
[ | ||
] | ||
|
||
--PACKAGE-REPOS-- | ||
[ | ||
[ | ||
{"name": "root/dep", "version": "1.2.0", "require": {"replacer/pkg": ">=1.1.0"}}, | ||
{"name": "replacer/pkg", "version": "1.0.0", "replace": {"replaced/pkg": "1.0.0"}}, | ||
{"name": "replacer/pkg", "version": "1.1.0"}, | ||
{"name": "replaced/pkg", "version": "1.0.0"}, | ||
{"name": "root/no-update", "version": "1.0.0", "require": {"replaced/pkg": "1.0.0"}} | ||
] | ||
] | ||
|
||
--EXPECT-- | ||
[ | ||
"root/no-update-1.0.0.0 (locked)", | ||
"root/dep-1.2.0.0", | ||
"replaced/pkg-1.0.0.0", | ||
"replacer/pkg-1.1.0.0" | ||
] | ||
|
||
--EXPECT-OPTIMIZED-- | ||
[ | ||
"root/no-update-1.0.0.0 (locked)", | ||
"root/dep-1.2.0.0", | ||
"replaced/pkg-1.0.0.0", | ||
"replacer/pkg-1.1.0.0" | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
tests/Composer/Test/Fixtures/installer/load-replaced-package-if-replacer-dropped.test
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
--TEST-- | ||
Ensure that a package gets loaded which was previously skipped due to replacement | ||
--COMPOSER-- | ||
{ | ||
"repositories": [ | ||
{ | ||
"type": "package", | ||
"package": [ | ||
{"name": "root/dep", "version": "1.2.0", "require": {"replacer/pkg": ">=1.1.0"}}, | ||
{"name": "replacer/pkg", "version": "1.0.0", "replace": {"replaced/pkg": "1.0.0"}}, | ||
{"name": "replacer/pkg", "version": "1.1.0"}, | ||
{"name": "replaced/pkg", "version": "1.0.0"}, | ||
{"name": "root/no-update", "version": "1.0.0", "require": {"replaced/pkg": "1.0.0"}} | ||
] | ||
} | ||
], | ||
"require": { | ||
"root/dep": "*", | ||
"root/no-update": "*" | ||
} | ||
} | ||
--LOCK-- | ||
{ | ||
"packages": [ | ||
{"name": "root/dep", "version": "1.1.0", "require": {"replacer/pkg": "1.*"}}, | ||
{"name": "replacer/pkg", "version": "1.0.0", "replace": {"replaced/pkg": "1.0.0"}}, | ||
{"name": "root/no-update", "version": "1.0.0", "require": {"replaced/pkg": "1.0.0"}} | ||
], | ||
"packages-dev": [], | ||
"aliases": [], | ||
"minimum-stability": "dev", | ||
"stability-flags": [], | ||
"prefer-stable": false, | ||
"prefer-lowest": false, | ||
"platform": [], | ||
"platform-dev": [] | ||
} | ||
--RUN-- | ||
update root/dep --with-all-dependencies | ||
--EXPECT-- | ||
Installing replacer/pkg (1.1.0) | ||
Installing root/dep (1.2.0) | ||
Installing replaced/pkg (1.0.0) | ||
Installing root/no-update (1.0.0) | ||
|