Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
COMPOSER_DISABLE_NETWORK aware
diagnose
checks; SKIP output (#11597)
Make `diagnose` checks aware of COMPOSER_DISABLE_NETWORK (true) and skip Composer network operations that would otherwise spill stack traces into diagnostic messages and taint the result as error while the check itself is not applicable/useful within the environment. `COMPOSER_DISABLE_NETWORK` was released with [2.0.0-alpha1] and intro- duced in fc03ab9 (Add COMPOSER_DISABLE_NETWORK env var for debugging, 2019-01-14). The previous behaviour was to exit with a status of two (2), denoting an error. The new behaviour is to exit with a status of zero (0), showing the successful skipping of diagnostics that can only be run when Composer network is enabled - not disabled. SKIP output is updated and streamlined. NOTE: The "prime" Value It is irrelevant for diagnose checks, as all diagnostic checks that spilled were with the HTTP Downloader and the check is aligned (both "1" or "prime" values disable): (bool) Platform::getEnv('COMPOSER_DISABLE_NETWORK') NOTE: Not Affected * The `allow_url_fopen` diagnostic check, platform related * The `disable-tls` setting related HTTP Downloader creation warning [2.0.0-alpha1]: <https://getcomposer.org/changelog/2.0.0-alpha1> "released 2020-06-03"
- Loading branch information