-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can this resource upload a directory tree? #66
Comments
Hi there! We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created. The current status is as follows:
This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes. |
Any chance of a comment on this ticket? This would be a really useful feature |
Just tried. It appears to hang indefinitely. |
It cannot upload directories. It uploads and keeps track of a single file. |
@vito The hanging thing is a bit disingenuous - might consider throwing an error or something? @tomwhoiscontrary I was pointed at https://github.com/18F/s3-resource-simple, which can do directories I believe. |
@jadekler Nice! If i ever use Concourse again, that will probably be very useful. |
See also #97 |
Well, can it? Or can it only upload a single file? The documentation doesn't touch on this.
Having read the code a bit, i think this depends on whether Go's glob function matches directories, and then on whether the AWS client handles directory trees, which it looks like it doesn't.
If this resource can't upload directories, can i suggest that (a) the documentation explicitly say so and (b) an attempt to upload a directory fails with an error saying so? I'm happy to submit a PR to do this.
Even better would be if it could upload directories, of course, but i suspect you won't want to do that.
The text was updated successfully, but these errors were encountered: