Uninline Mutex::Dtor also on linux #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
requested review from
bluescarni,
njzjz and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
3 tasks
xhochy
approved these changes
Feb 22, 2024
|
Thanks for taking the time to check and read through the upstream issue too! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-around for abseil/abseil-cpp#1624; this might just be how things be with shared builds, or it's possible that a smarter fix can be found. In any case, the abseil migration is burning a hole into the floor right now, and we should unblock it, and let upstream figure out a fix in their own time, which we can then integrate in the mid-year release (even in the most pessimistic scenario).
The Dtor is already not inline on windows (for shared builds) and macOS, so it's not like this is unknown territory. It was also tested to work in the dev-channel with #75 + conda-forge/grpc-cpp-feedstock#350 already.