Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arcticdb v4.4.0rc1 #184

Merged
merged 10 commits into from
Mar 28, 2024
Merged

arcticdb v4.4.0rc1 #184

merged 10 commits into from
Mar 28, 2024

Conversation

IvoDD
Copy link
Contributor

@IvoDD IvoDD commented Mar 28, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: host: folly==2023.09.25.00 must contain a space between the name and the pin, i.e. folly ==2023.09.25.00

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@IvoDD
Copy link
Contributor Author

IvoDD commented Mar 28, 2024

@conda-forge-admin, please rerender

jjerphan
jjerphan reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IvoDD.

I just have a few comments, apart from them, everything LGTM.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
IvoDD and others added 3 commits March 28, 2024 10:55
@IvoDD @jjerphan
Remove folly pin
e82a6e5 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@IvoDD @jjerphan
Use non-post protobuf version
2412291 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@IvoDD
Update c standard library
0e4f90d
@IvoDD
Copy link
Contributor Author

IvoDD commented Mar 28, 2024

@conda-forge-admin, please rerender

@IvoDD
Copy link
Contributor Author

IvoDD commented Mar 28, 2024

@conda-forge-admin, please rerender

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/8466727367.

@IvoDD
Copy link
Contributor Author

IvoDD commented Mar 28, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits March 28, 2024 13:37
@IvoDD
Copy link
Contributor Author

IvoDD commented Mar 28, 2024

@conda-forge-admin, please rerender

jjerphan
jjerphan approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given 🟢 CI checks.

The build of unordered_dense for osx_arm64 should be available in a few dozens minutes.

@jjerphan jjerphan added the automerge Merge the PR when CI passes label Mar 28, 2024
@jjerphan jjerphan changed the title ArcticDB v4.4.0rc1 arcticdb v4.4.0rc1 Mar 28, 2024
@github-actions github-actions bot merged commit 8ce7168 into conda-forge:rc Mar 28, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan approved these changes

@DerThorsten DerThorsten Awaiting requested review from DerThorsten DerThorsten is a code owner

@G-D-Petrov G-D-Petrov Awaiting requested review from G-D-Petrov G-D-Petrov is a code owner

@Hind-M Hind-M Awaiting requested review from Hind-M Hind-M is a code owner

@JohanMabille JohanMabille Awaiting requested review from JohanMabille JohanMabille is a code owner

@Klaim Klaim Awaiting requested review from Klaim Klaim is a code owner

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 is a code owner

@jamesmunro jamesmunro Awaiting requested review from jamesmunro jamesmunro is a code owner

@joe-iddon joe-iddon Awaiting requested review from joe-iddon joe-iddon is a code owner

@mehertz mehertz Awaiting requested review from mehertz mehertz is a code owner

@phoebusm phoebusm Awaiting requested review from phoebusm phoebusm is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars is a code owner

@qc00 qc00 Awaiting requested review from qc00 qc00 is a code owner

@vasil-pashov vasil-pashov Awaiting requested review from vasil-pashov vasil-pashov is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvoDD @jjerphan