Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Rebuild for libabseil20230125 #975

Merged
merged 6 commits into from
Mar 4, 2023
Merged

[main] Rebuild for libabseil20230125 #975

merged 6 commits into from
Mar 4, 2023

Conversation

h-vetinari
Copy link
Member

Bot stuck on tensorflow

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Feb 24, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@h-vetinari
Copy link
Member Author

It seems this is segfaulting in test_flight.py::test_flight_list_flights on osx-64 both for arrow 10 & 11, might be related to conda-forge/grpc-cpp-feedstock#281, which I haven't had time to look into yet...

CC @xhochy @kkraus14 @kou @pitrou @coryan

@h-vetinari
Copy link
Member Author

It seems this is segfaulting in test_flight.py::test_flight_list_flights on osx-64 both for arrow 10 & 11

Looking at the source of that test and the utility class ConstantFlightServer, it notes:

See ARROW-4796: this server implementation will segfault if Flight
does not properly hold a reference to the Table object.

@h-vetinari
Copy link
Member Author

@kou @pitrou
Any idea what might be causing these segfaults on osx? This is now holding up other migrations like re2... 😢

@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Mar 1, 2023
@h-vetinari
Copy link
Member Author

@conda-forge/arrow-cpp @kou @pitrou @jorisvandenbossche @kkraus14

A lot of migrations are starting to pile up on the missing abseil migration for arrow 10/11. I'm going to skip the flight tests on osx now to unblock this. Any input/help is welcome.

@kkraus14
Copy link
Contributor

kkraus14 commented Mar 3, 2023

@conda-forge/arrow-cpp @kou @pitrou @jorisvandenbossche @kkraus14

A lot of migrations are starting to pile up on the missing abseil migration for arrow 10/11. I'm going to skip the flight tests on osx now to unblock this. Any input/help is welcome.

I'll ping a few folks internally to see if I can get someone to jump in here.

@h-vetinari h-vetinari merged commit 213bdd9 into conda-forge:main Mar 4, 2023
@h-vetinari h-vetinari deleted the abseil branch March 4, 2023 02:29
@h-vetinari h-vetinari mentioned this pull request Mar 4, 2023
Closed
@h-vetinari h-vetinari mentioned this pull request Jul 27, 2023
Closed
@h-vetinari
Copy link
Member Author

I'll ping a few folks internally to see if I can get someone to jump in here.

@kkraus14, not sure what ever came of this, but there's now an upstream issue to track this: apache/arrow#36908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@jreback jreback Awaiting requested review from jreback jreback is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@kszucs kszucs Awaiting requested review from kszucs kszucs is a code owner

@leifwalsh leifwalsh Awaiting requested review from leifwalsh leifwalsh is a code owner

@nealrichardson nealrichardson Awaiting requested review from nealrichardson nealrichardson is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@pearu pearu Awaiting requested review from pearu pearu is a code owner

@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner

@robertnishihara robertnishihara Awaiting requested review from robertnishihara robertnishihara is a code owner

@siddharthteotia siddharthteotia Awaiting requested review from siddharthteotia siddharthteotia is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @kkraus14