Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add definition of m2w64_c_stdlib on windows #5832

Merged
merged 1 commit into from
May 6, 2024

Conversation

h-vetinari
Copy link
Member

As suggested by @isuruf. Compiler comes from here.

I don't know if this needs a corresponding m2w64_c_stdlib_version, please advise.

Co-Authored-By: Isuru Fernando <isuruf@gmail.com>
@h-vetinari h-vetinari requested a review from isuruf May 2, 2024 00:49
@h-vetinari h-vetinari requested a review from a team as a code owner May 2, 2024 00:49
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Just noticed that you're using

cross_target_stdlib_version:
  - 9
cross_target_stdlib:
  - m2w64-sysroot

in https://github.com/conda-forge/ctng-compilers-feedstock/pull/130/files. I don't know the m2w64 stack, but I'm guessing that m2w64-sysroot is closer to what we want for the stdlib than m2w64-toolchain?

@isuruf
Copy link
Member

isuruf commented May 6, 2024

I don't know the m2w64 stack, but I'm guessing that m2w64-sysroot is closer to what we want for the stdlib than m2w64-toolchain?

That's still experimental.

@isuruf isuruf merged commit 5b2fc9a into conda-forge:main May 6, 2024
4 checks passed
@isuruf
Copy link
Member

isuruf commented May 6, 2024

We also need to fix the piggy-back migrator

@h-vetinari h-vetinari deleted the m2w64 branch May 6, 2024 18:11
@h-vetinari
Copy link
Member Author

We also need to fix the piggy-back migrator

Can you open an issue with what should be done on cf-scripts?

@isuruf
Copy link
Member

isuruf commented May 6, 2024

See regro/cf-scripts#2547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants