Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Take into account stdlib_version for determining macOS SDK version in .ci_support/ and cf-ci-setup #1884

Closed
Tracked by #2102
h-vetinari opened this issue Mar 22, 2024 · 2 comments · Fixed by #1889

Comments

@h-vetinari
Copy link
Member

With the introduction of {{ stdlib("c") }} and macosx_deployment_target, we have a new & better way to specify the required macosx deployment target. However, that means if people change to the new way, we need to take that into account when setting up the CI image (i.e. download_osx_sdk.sh in the ci-setup).

Additionally, we should warn about doubly specified deployment targets in cbc.yaml. My suggested proposal is:

  • warn in smithy if MACOSX_DEPLOYMENT_TARGET is specified in cbc.yaml
  • error in smithy if MACOSX_DEPLOYMENT_TARGET is in contradiction with a local c_stdlib_version on osx (not the one coming from the global pinning)
  • keep writing MACOSX_DEPLOYMENT_TARGET to the .ci_support/*.yaml files, filled by whatever is in c_stdlib_version on osx
  • that way, we don't need to touch the conda-forge-ci logic, which can keep working as-is for MACOSX_DEPLOYMENT_TARGET / MACOSX_SDK_VERSION.

Thoughts? @isuruf @mbargull @beckermr

@beckermr
Copy link
Member

SGTM!

We probably want to have a linting errors for certain things (like the first bullet point) in addition to smithy warnings.

@isuruf
Copy link
Member

isuruf commented Mar 22, 2024

Let's do the warning for a few releases and switch to an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants