-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cuda-python v12.2.0 #40
cuda-python v12.2.0 #40
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin , please re-render |
…nda-forge-pinning 2023.12.19.13.04.28
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin , please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-python-feedstock/actions/runs/7271545751. |
@conda-forge-admin , please re-render |
…nda-forge-pinning 2023.12.19.13.04.28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on a few notable changes below that fall out of resolving upstream issue ( NVIDIA/cuda-python#44 ). Namely adding Python 3.12, which resolves issue ( #57 ), and adding Cython 3
recipe/meta.yaml
Outdated
# Cython 0.29.x seems not to be fully compatible with Python 3.12, skipping for now. | ||
# This can be removed in a later CUDA Python that supports Cython 3.x. | ||
# xref: https://github.com/conda-forge/cuda-python-feedstock/issues/57 | ||
skip: true # [py == 312] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As CUDA-Python 12.2.0 has a fix for issue ( NVIDIA/cuda-python#44 ), we can drop the Python 3.12 skip
thus fixing issue ( #57 )
recipe/meta.yaml
Outdated
host: | ||
- cuda-cudart-dev | ||
- cuda-nvrtc-dev | ||
- cuda-profiler-api | ||
- cython <3 | ||
- cython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also issue ( NVIDIA/cuda-python#44 ) fixes Cython 3 support, so we can drop this upper bound on Cython
recipe/meta.yaml
Outdated
@@ -46,12 +42,12 @@ requirements: | |||
- sysroot_{{ target_platform }} 2.17 # [linux] | |||
- cross-python_{{ target_platform }} # [build_platform != target_platform] | |||
- python # [build_platform != target_platform] | |||
- cython <3 # [build_platform != target_platform] | |||
- cython # [build_platform != target_platform] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which of course can be repeated for the cross-compilation case where Cython is needed in requirements/build
This will fail until we have completed adding CUDA 12.2 to conda-forge ( conda-forge/cuda-feedstock#13 ) However we are getting pretty close to finishing that goal. So went ahead and refreshed this PR. Also wanted to make a few of the notable changes above before I might forget them (over the holidays) Should hopefully get this into a good state to ship once CUDA 12.2 is ready |
As GitHub archives are dynamically generated and that process can introduce changes from time to time, the checksum unfortunately can change as well. Update the checksum to match a recently downloaded GitHub archive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Great to have the fixes for Cython 3 and Python 3.12. :)
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.01.05.22.51.09
This is now building with CUDA 12.2 However am seeing the following error on CI: cuda/cudart.cpp: In function 'PyObject* __pyx_tp_new_4cuda_6cudart_cudaGraphNodeParams(PyTypeObject*, PyObject*, PyObject*)':
cuda/cudart.cpp:360541:74: error: use of deleted function 'cudaGraphNodeParams::cudaGraphNodeParams()'
360541 | new((void*)&(p->_cudaGraphNodeParams__val)) struct cudaGraphNodeParams();
| ^
In file included from cuda/cudart.cpp:1243:
/home/conda/feedstock_root/build_artifacts/cuda-python_1704514350782/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/targets/x86_64-linux/include/driver_types.h:3041:27: note: 'cudaGraphNodeParams::cudaGraphNodeParams()' is implicitly deleted because the default definition would be ill-formed:
3041 | struct __device_builtin__ cudaGraphNodeParams {
| ^~~~~~~~~~~~~~~~~~~
/home/conda/feedstock_root/build_artifacts/cuda-python_1704514350782/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/targets/x86_64-linux/include/driver_types.h:3047:56: error: union member 'cudaGraphNodeParams::<unnamed union>::kernel' with non-trivial 'cudaKernelNodeParamsV2::cudaKernelNodeParamsV2()'
3047 | struct cudaKernelNodeParamsV2 kernel;
| ^~~~~~
error: command '/home/conda/feedstock_root/build_artifacts/cuda-python_1704514350782/_build_env/bin/x86_64-conda-linux-gnu-cc' failed with exit code 1
error: subprocess-exited-with-error Edit: Maybe this is related to issue ( NVIDIA/cuda-python#55 )? |
This reverts commit 21a0944. Looks like there are still issues with Cython 3. So reverting these changes until those are corrected.
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.01.08.19.20.26
Looks like there are still issues with Cython 3 in CUDA-Python 12.2.0. So have reverted that |
Thanks all! 🙏 Adding |
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.01.08.19.20.26
Merged with |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Closes: #39
Fixes #57
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5404320976, please use this URL for debugging.