Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for Windows + CUDA 12 #228

Merged
merged 69 commits into from
Nov 17, 2023
Merged

Build for Windows + CUDA 12 #228

merged 69 commits into from
Nov 17, 2023

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Nov 2, 2023 •
edited by leofang
Loading

Close #205.

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #205.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Nov 2, 2023
Closed
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang leofang marked this pull request as draft November 2, 2023 13:44
@leofang
Copy link
Member

leofang commented Nov 2, 2023

@conda-forge-admin, please rerender

@leofang leofang changed the title MNT: rerender [DO NOT MERGE] Build for Windows + CUDA 12 Nov 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cupy-feedstock/actions/runs/6733459902.

@leofang
Copy link
Member

leofang commented Nov 2, 2023

@conda-forge-admin, please rerender

@leofang
Copy link
Member

leofang commented Nov 2, 2023

@conda-forge-admin, please rerender

@leofang
Copy link
Member

leofang commented Nov 2, 2023

It seems conda-smithy would ignore the local migrator if it's already included in the pinning feedstock. Changes made are either no effect or ruining everything. Let me prepare a new migrator..

@leofang
Copy link
Member

leofang commented Nov 2, 2023

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits November 2, 2023 14:19
@leofang
Copy link
Member

leofang commented Nov 2, 2023

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits November 2, 2023 14:32
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge-webservices[bot] and others added 2 commits November 8, 2023 20:25
@jakirkham
Copy link
Member

Some of the Windows CUDA 12 jobs timed out when creating the .conda package after the build. Going to try restarting them

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

leofang
leofang reviewed Nov 10, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

FWIW just testing to see that the conda-forge-ci-setup changes are working as expected. So far so good

@jakirkham jakirkham mentioned this pull request Nov 10, 2023
Merged
7 tasks
This was referenced Nov 10, 2023
Merged
Closed
@jakirkham @leofang
Cleanup
44c9f69 
Co-authored-by: Leo Fang <leof@nvidia.com>
@jakirkham
Copy link
Member

FWIW started PRs to update some dependencies for CUDA 12 Windows:

@leofang
Copy link
Member

leofang commented Nov 16, 2023

Let me apply the migrator here, wait for all dependencies to be ready, and then squash-merge.

@leofang leofang changed the title [DO NOT MERGE] Build for Windows + CUDA 12 Build for Windows + CUDA 12 Nov 16, 2023
@leofang
Copy link
Member

leofang commented Nov 16, 2023

@conda-forge-admin, please rerender

leofang
leofang reviewed Nov 16, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@leofang leofang marked this pull request as ready for review November 16, 2023 22:51
@leofang
Copy link
Member

leofang commented Nov 16, 2023

It'd take some time to get the CDN sync'd, given the cudnn PR just got merged (conda-forge/cudnn-feedstock#66).

@leofang leofang closed this Nov 17, 2023
@leofang leofang reopened this Nov 17, 2023
jakirkham
jakirkham approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Leo! 🙏

Going to add automerge so it merges after CI. Hope that is ok 🙂

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Nov 17, 2023
@github-actions github-actions bot merged commit 11d783c into conda-forge:main Nov 17, 2023
34 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@leofang leofang mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang left review comments

@jakirkham jakirkham jakirkham approved these changes

@asi1024 asi1024 Awaiting requested review from asi1024 asi1024 is a code owner

@emcastillo emcastillo Awaiting requested review from emcastillo emcastillo is a code owner

@kmaehashi kmaehashi Awaiting requested review from kmaehashi kmaehashi is a code owner

@toslunar toslunar Awaiting requested review from toslunar toslunar is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support CUDA 12 + Windows
3 participants
@conda-forge-admin @leofang @jakirkham