Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS LAMMPS plugin loading issue #72

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 17, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Patch deepmodeling/deepmd-kit#3473.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@njzjz
Copy link
Member Author

njzjz commented Mar 17, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits March 17, 2024 00:24
@njzjz
Copy link
Member Author

njzjz commented Mar 17, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/deepmd-kit-feedstock/actions/runs/8312126200.

@njzjz
Copy link
Member Author

njzjz commented Mar 19, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/deepmd-kit-feedstock/actions/runs/8350250638.

@chazeon
Copy link

chazeon commented Mar 19, 2024

Hi @njzjz, see this issue conda-forge/conda-forge.github.io#2102, it seems that you will also need to add c_stdlib and c_stdlib_version to conda_build_config.yaml to make {{ stdlib("c") }} work.

@njzjz
Copy link
Member Author

njzjz commented Mar 19, 2024

Hi @njzjz, see this issue conda-forge/conda-forge.github.io#2102, it seems that you will also need to add c_stdlib and c_stdlib_version to conda_build_config.yaml to make {{ stdlib("c") }} work.

The global pining has contained it: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/3c7d60f56a8cb7d1b8f5a8da0b02ae1f1f0982d7/recipe/conda_build_config.yaml#L11-L24
The issue seems to be due to an old version of conda-build: conda-forge/conda-build-feedstock#220

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jinzhe, sorry for the trouble here

Added a suggestion below

Also may want to add this to conda-forge.yml

os_version:
  linux_64: cos7
  linux_aarch64: cos7
  linux_ppc64le: cos7

Then would re-render for these to take effect

recipe/meta.yaml Outdated Show resolved Hide resolved
njzjz and others added 2 commits March 21, 2024 22:09
Co-authored-by: jakirkham <jakirkham@gmail.com>
@njzjz
Copy link
Member Author

njzjz commented Mar 22, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/deepmd-kit-feedstock/actions/runs/8384464227.

@njzjz
Copy link
Member Author

njzjz commented Mar 22, 2024

@conda-forge-admin, please rerender

@njzjz njzjz added the automerge Merge the PR when CI passes label Mar 22, 2024
@github-actions github-actions bot merged commit 8f63c8d into conda-forge:main Mar 22, 2024
38 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants