Revert "Cleanup and consolidate CUDA images" #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conda-forge/core, mind approving this? |
hmaarrfk
reviewed
Jul 11, 2024
There was a problem hiding this comment.
ok.... but lets try to avoid this kind of churn in the future and instead try to fail "forward" together in the future.
I know sometimes it is important to move fast in the two PRs referenced in particular.
We had the most knowledgeable people in the both cases pushing good refactors.
Merge this if you want, but the change looks good to me whether or not i look at the red lines or the green lines.
One thing to consider would be to let it go this one time to save yourself future churn 🤷🏾
hmaarrfk
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #272
Since this PR didn't have a proper review. I'm reverting this and will consider sending it again.