Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build number to rebuild osx-64 #21

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

beenje
Copy link
Contributor

@beenje beenje commented May 14, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

osx-64 build failed when merging into main because libcxx was updated from 16.x.x to 17.x.x between the time of the MR and the merge. libcxx 17.x.x requires MacOS >=10.13 (see conda-forge/libcxx-feedstock#131)

My understanding is that a re-render should fix it due to conda-forge/conda-forge-pinning-feedstock#5829

osx-64 build failed when merging into main because libcxx was updated from 16.x.x
to 17.x.x between the time of the MR and the merge.
libcxx 17.x.x requires MacOS >=10.13 (see conda-forge/libcxx-feedstock#131)

My understanding is that a re-render should fix it due to conda-forge/conda-forge-pinning-feedstock#5829
@beenje beenje requested a review from tschoonj as a code owner May 14, 2024 06:50
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beenje
Copy link
Contributor Author

beenje commented May 14, 2024

@conda-forge-admin, please rerender

@beenje
Copy link
Contributor Author

beenje commented May 14, 2024

Thanks for merging #20 @tschoonj !

Unfortunately I saw that the osx-64 build failed. This is because libcxx was updated to 17.x.x in the meantime and that required a re-render to increase the minimum macOS deployment target to 10.13.
This is what I did in this PR.

@tschoonj tschoonj added the automerge Merge the PR when CI passes label May 14, 2024
Copy link
Contributor

@tschoonj tschoonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: failed
  • azure: passed

Thus the PR was not passing and not merged.

Travis CI is not very reliable.
Switch to azure and cross-compiling for aarch64 and ppcle64
@beenje
Copy link
Contributor Author

beenje commented May 14, 2024

@conda-forge-admin, please rerender

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label May 14, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@beenje
Copy link
Contributor Author

beenje commented May 14, 2024

Travis CI is not very reliable and really slow.
Trying to switch to azure and cross-compiling for linux aarch64 and ppcle64

@beenje
Copy link
Contributor Author

beenje commented May 15, 2024

@tschoonj the move to azure for linux aarch64 and ppcle64 went well.
I think that will improve the pipeline. Ready to be merged again.

@tschoonj tschoonj merged commit 9200a25 into conda-forge:main May 15, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants