Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with minimum jaxlib version #130

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Test with minimum jaxlib version #130

merged 4 commits into from
Oct 24, 2023

Conversation

apmorton
Copy link
Contributor

@apmorton apmorton commented Oct 19, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See: https://github.com/google/jax/blob/jaxlib-v0.4.16/jax/version.py#L122

@apmorton apmorton changed the title Am/add pin Fix jaxlib pin Oct 19, 2023
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@apmorton apmorton mentioned this pull request Oct 19, 2023
Merged
5 tasks
@apmorton apmorton changed the title Fix jaxlib pin Test with minimum jaxlib version Oct 23, 2023
ngam
ngam approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ngam ngam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ocefpaf ocefpaf merged commit 3445135 into conda-forge:main Oct 24, 2023
3 checks passed
@ngam ngam mentioned this pull request Oct 24, 2023
Open
@apmorton apmorton deleted the am/add-pin branch October 24, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

@ngam ngam ngam approved these changes

@ericmjl ericmjl Awaiting requested review from ericmjl ericmjl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apmorton @ocefpaf @ngam