Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to set environment variable IGNITION_VERSION? #41

Open
1 task done
wolfv opened this issue Jun 27, 2022 · 3 comments
Open
1 task done

Do we need to set environment variable IGNITION_VERSION? #41

wolfv opened this issue Jun 27, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@wolfv
Copy link
Member

wolfv commented Jun 27, 2022

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

In the CMakeLists of "dolly" they check for the env var of IGNITION_VERSION to be set to "fortress" in order to search for ignition-gazebo6.

I was wondering if we should also set that in an activation script? Thoughts?

https://github.com/chapulina/dolly/blob/de9efdf34235d749b9f3b458607d554816304b88/dolly_ignition/CMakeLists.txt#L6-L11

Installed packages

-

Environment info

-
@wolfv wolfv added the bug Something isn't working label Jun 27, 2022
@Tobias-Fischer
Copy link
Contributor

Yes I think I've seen this elsewhere (the ROS ign packages maybe). Good idea!

@traversaro
Copy link
Contributor

In the specific case, IGNITION_VERSION is specified by the CI, see https://github.com/chapulina/dolly/blob/6a9b6d698a38cca092901257ca4343d8b2a40176/.github/workflows/ci.yml#L33 . I would be inclined not to define such a variable, for two main reasons:

  • Consistency with apt/homebrew packages: I do not think any apt/homebrew package of Modern Gazebo (i.e. what was formerly known as Ignition) defines it
  • As "Modern Gazebo"/Ignition distributions are meant to be side-by-side installable I am not sure setting, I do not think it make sense to have a single env variable.

However, I would need to check how ros_ign build system works. Perhaps @chapulina herself may have some input on this?

@wolfv
Copy link
Member Author

wolfv commented Jun 27, 2022

Actually, i saw that in the released version of this package Gazebo5 is hard coded... sadly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants