Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with CUDA 12 #85

Merged
merged 57 commits into from
Jun 1, 2023

Conversation

pentschev
Copy link
Contributor

@pentschev pentschev commented Apr 13, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Update UCX to build CUDA 12 from new packaging format and CUDA 10/11 with the legacy cudatoolkit package. Building with qemu segfaults, so switching back to Travis was necessary but that caused ppc64le builds to timeout and were thus disabled, at least until cross-compiling is stable (see #88).

Fixes #82
Closes #86
Closes #89

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pentschev pentschev changed the title Build with CUDA 12 from nvidia channel [NO MRG]: Build with CUDA 12 Apr 13, 2023
@jakirkham
Copy link
Member

jakirkham commented Apr 13, 2023

@conda-forge-admin, please re-render

Edit: Relevant re-rendering job on GHA

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nccl-feedstock/actions/runs/4687945521.

@leofang
Copy link
Member

leofang commented Apr 13, 2023

Seems to be compiling (on linux64)!

@pentschev pentschev changed the title [NO MRG]: Build with CUDA 12 Build with CUDA 12 Apr 24, 2023
@pentschev pentschev marked this pull request as ready for review April 24, 2023 20:08
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

conda-forge.yml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nccl-feedstock/actions/runs/5136607785.

Edit: Rerunning this job as there was a 404 error

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nccl-feedstock/actions/runs/5136607785.

Edit: There were some package issues that are now resolved ( conda-forge/conda-forge-pinning-feedstock#4525 (comment) ). Rerunning

@leofang leofang mentioned this pull request Jun 1, 2023
3 tasks
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nccl-feedstock/actions/runs/5148156191.

recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting how cudart_static is set, nothing to do here :)

recipe/build.sh Show resolved Hide resolved
recipe/build.sh Show resolved Hide resolved
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks to you both, Peter & John!

@leofang leofang added the automerge Merge the PR when CI passes label Jun 1, 2023
@leofang leofang mentioned this pull request Jun 1, 2023
@github-actions github-actions bot merged commit 6cce7b8 into conda-forge:main Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@pentschev pentschev deleted the cuda-12-nvidia-channel branch June 24, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCCL: Support CUDA 12
4 participants