Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated beta for 8.0 #85

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Updated beta for 8.0 #85

merged 4 commits into from
Sep 14, 2022

Conversation

peastman
Copy link
Contributor

@peastman peastman commented Sep 13, 2022

Checklist

We finally have the OpenMM-Torch build issues resolved and can move forward with the beta. This updates the source revision to get the latest changes.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@peastman
Copy link
Contributor Author

@conda-forge-admin, please rerender

@peastman
Copy link
Contributor Author

All of the builds for ARM Mac failed with this error:

2022-09-13T19:51:11.9299260Z /Users/runner/miniforge3/etc/profile.d/conda.sh: line 9:  6048 Segmentation fault: 11  "$CONDA_EXE" $_CE_M $_CE_CONDA "$@"

Any idea what could be causing it?

@peastman
Copy link
Contributor Author

Possibly it's related to the fact that tests only get run on ARM? @jaimergp it looks like you introduced that in a commit on Jan. 21, 2021. Do you remember why? In any case, it passed when we did the last build two months ago.

@jaimergp
Copy link
Member

IIRC, it's due to the fact we can't run ARM64 code on the regular CI.

We included this line

{% set with_test_suite = "true" %} # [(osx and arm64)]

so the tests get included in the final package, and we could test the artifacts locally, because we couldn't be sure cross-compilation was not introducing errors in the unit tests. If you are confident the process works ok, I guess you can remove it!

@jaimergp
Copy link
Member

It might also do with the patching we needed for OSX tests, which had wrong rpaths or something. The patching was needed to make tests relocatable, iirc. This way people can test the package locally with conda build --test <tarball>. But if that's getting in the way, go ahead and skip it.

It'd be nice to know why it's segfaulting now, though. I'd start by comparing the versions of the packages installed in the build and host environments in both commits, but up to you.

@peastman
Copy link
Contributor Author

Let's try leaving out the tests and see what happens. Something upstream must have changed in the last two months to cause the error to appear.

@peastman
Copy link
Contributor Author

That seems to have worked. Shrug? Since this is just a beta, let's go ahead with it. We'll see if any problems come up when users start working with it.

@peastman peastman merged commit c19408b into conda-forge:rc Sep 14, 2022
@peastman peastman deleted the 80beta branch September 14, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants