-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated beta for 8.0 #85
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.09.13.19.09.01
All of the builds for ARM Mac failed with this error:
Any idea what could be causing it? |
Possibly it's related to the fact that tests only get run on ARM? @jaimergp it looks like you introduced that in a commit on Jan. 21, 2021. Do you remember why? In any case, it passed when we did the last build two months ago. |
IIRC, it's due to the fact we can't run ARM64 code on the regular CI. We included this line openmm-feedstock/recipe/meta.yaml Line 5 in 036712c
so the tests get included in the final package, and we could test the artifacts locally, because we couldn't be sure cross-compilation was not introducing errors in the unit tests. If you are confident the process works ok, I guess you can remove it! |
It might also do with the patching we needed for OSX tests, which had wrong rpaths or something. The patching was needed to make tests relocatable, iirc. This way people can test the package locally with It'd be nice to know why it's segfaulting now, though. I'd start by comparing the versions of the packages installed in the build and host environments in both commits, but up to you. |
Let's try leaving out the tests and see what happens. Something upstream must have changed in the last two months to cause the error to appear. |
That seems to have worked. Shrug? Since this is just a beta, let's go ahead with it. We'll see if any problems come up when users start working with it. |
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)We finally have the OpenMM-Torch build issues resolved and can move forward with the beta. This updates the source revision to get the latest changes.