Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libhwloc 2.9.3 #141

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update libhwloc293.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7645341919, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dalcinl dalcinl self-assigned this Jan 25, 2024
@dalcinl
Copy link
Contributor

dalcinl commented Jan 25, 2024

@leofang @minrk The migrator moved this recipe to use cross-compilation for linux-aarch64. I pushed a quick fix assuming without checking that Fortran datatypes have the same size/alignment in osx-arm64 and linux-aarch64.

@dalcinl
Copy link
Contributor

dalcinl commented Jan 25, 2024

BTW, now that we are at it, why don't we just cross-compile in linux-ppc64le as well?

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cross-compiled linux builds are tested under emulation (unlike mac arm), so presumably that's confirmation that it is correct?

Since arm seems to be working, we could also try switching ppc to cross-compiled, which would save ~2 hours per build (not for this PR).

@leofang
Copy link
Member

leofang commented Jan 25, 2024

Interesting that you made it work, if the assumption holds it'd be nice to cross compile, see the earlier discussion here #121 (comment).

@dalcinl
Copy link
Contributor

dalcinl commented Jan 25, 2024

cross-compiled linux builds are tested under emulation

Oh, boy... I didn't know cross-compiled packages were tested under emulation!
I'll definitely try to switch ppc64le to cross-compilation.

@dalcinl dalcinl force-pushed the rebuild-libhwloc293-0-1_hedaffe branch 2 times, most recently from 268c560 to 24bc889 Compare January 25, 2024 18:54
@dalcinl
Copy link
Contributor

dalcinl commented Jan 25, 2024

@leofang @minrk I'm way out of my comfort zone with this PR. May I ask for your quick review again?
The various config variables in cross-gfortran.$target_arch.sh were obtained fresh with runs on native macOS arm64 and emulated aarch64/ppc64le under popman.

@leofang
Copy link
Member

leofang commented Jan 29, 2024

cross-compiled linux builds are tested under emulation

Oh, boy... I didn't know cross-compiled packages were tested under emulation! I'll definitely try to switch ppc64le to cross-compilation.

Note: this is because we set test_on_native_only: True, which is deprecated and mapped to test: native_and_emulated. So we get the QEMU for free when cross compiling.

The various config variables in cross-gfortran.$target_arch.sh were obtained fresh with runs on native macOS arm64 and emulated aarch64/ppc64le under popman.

@dalcinl Could you add a note to educate us how it was generated? I keep asking the original authors on both mpich/openmpi feedstocks and no one responded. If you figured it out, let's make sure I and future us know how to maintain.

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for two nits (update the deprecated config field and add comments).

conda-forge.yml Outdated Show resolved Hide resolved
@dalcinl dalcinl force-pushed the rebuild-libhwloc293-0-1_hedaffe branch from 24bc889 to 6523121 Compare January 29, 2024 09:13
@dalcinl
Copy link
Contributor

dalcinl commented Jan 29, 2024

@leofang You are asking me to write down documentation. How dare you?

@dalcinl
Copy link
Contributor

dalcinl commented Jan 29, 2024

Are the comments I added good enough?

export ompi_cv_fortran_sizeof_type_test_mpi_handle_=4
export ompi_cv_fortran_true_value=1
export ompi_cv_fortran_use_only=yes
export ompi_cv_real16_c_equiv=yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsquyres This is a very minor nit.. but ompi_cv_real16_c_equiv is the only Fortran-related variable required for cross compiling that does not use a mpi_cv_fortran_ prefix (note the missing fortran_ bit). Would it make sense to rename it to follow the pattern of all the others variables?

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lisandro, LGTM!

@leofang leofang merged commit efdc204 into conda-forge:main Jan 29, 2024
10 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libhwloc293-0-1_hedaffe branch January 29, 2024 14:45
@leofang
Copy link
Member

leofang commented Jan 29, 2024

For some reason the linux64 CI has failed repeatedly, seems related to some invalid utf-8 characters detected by LIEF at run time.
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=866388&view=logs&jobId=aaada960-d85f-5b88-82e5-99df4d27a2ce&j=aaada960-d85f-5b88-82e5-99df4d27a2ce&t=0aca0cbb-1f96-540a-bae4-6a7030c11d7d

@dalcinl
Copy link
Contributor

dalcinl commented Jan 30, 2024

What are we supposed to do? Should we try triggering a new build?

@leofang
Copy link
Member

leofang commented Jan 30, 2024

Asking in the CF Gitter channel, let's see if anyone can help... I haven't seen this before

@dalcinl
Copy link
Contributor

dalcinl commented Feb 1, 2024

Any news? Out of better ideas, I just restarted the build.

@leofang leofang mentioned this pull request Feb 5, 2024
5 tasks
@leofang
Copy link
Member

leofang commented Feb 5, 2024

Error reproduced in #142.

!/recipe/**
!/.ci_support/**

# Since we ignore files/folders recursively, any folders inside
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leofang Maybe this change triggered some unintended consequence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants