-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
or-tools v9.7 #47
base: main
Are you sure you want to change the base?
or-tools v9.7 #47
Conversation
…nda-forge-pinning 2023.08.08.11.45.19
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@Mizux, there's a problem with
In particular, it seems there are type conversions missing.
Also, does 9.7 only support protobuf >=4.23.3 or should I still expect it to be buildable (even if non-standard) with 3.21? We still haven't flipped the switch to stop building 3.21, so if possible I'd like to build for both (but not extremely important). |
IIRC this may due to:
Seems likely the 2, started from v9.7 we are using Protobuf v23.3 (i.e. abseil-cpp based version)... |
Conda-forge's re2 is using
Yeah, I copied the wrong error (was too busy this morning 🙈). It's fine to drop support for 3.21 then. Guess I'll have to dig into the errors on protobuf 4, which indeed look related to |
for re2 not anymore, for abseil-cpp small patch https://github.com/google/or-tools/blob/stable/patches/abseil-cpp-20230125.3.patch (IIRC mostly add log because since cmake 3.19 ) Still need to investigate and send an error to kitware/abseil-cpp to confirm the behaviour and find a clean fix. |
Needs: * re2 update (in staging currently) * pybind11_protobuf (for Python bindings) - CMake build system is kind of broken: pybind/pybind11_protobuf#128 - Needs protobuf proto_api.h, which isn't installed and upstream says wontfix: protocolbuffers/protobuf#9464 See also: * conda-forge/or-tools-feedstock#47 * pybind/pybind11_protobuf#60
Needs: * re2 update (in staging currently) * pybind11_protobuf (for Python bindings) - CMake build system is kind of broken: pybind/pybind11_protobuf#128 - Needs protobuf proto_api.h, which isn't installed and upstream says wontfix: protocolbuffers/protobuf#9464 See also: * conda-forge/or-tools-feedstock#47 * pybind/pybind11_protobuf#60
c4f80ac
to
903390f
Compare
@Mizux this still fails with an incompatibility between
I'm not 100% I understand what you mean here - is there still something in or-tools that could force compilation with C++14? That would be a possible explanation for the ABI-mismatch. |
don't know if it help but on %git grep StringPiece and we are using
so ortools seems to use an re2 version which rely on absl::string_view (when using note: https://github.com/google/re2/releases seems there is a |
Thanks for the response!
It's my understanding that these should be compatible (when both compiled with C++17), see the comment above. So I'm surprised why this shouldn't work.
Yes. It's currently 2023.03.01. Normally we're much faster with upgrading, but we have a discussion that got stuck in conda-forge/re2-feedstock#68, and I haven't had time/energy to get it unstuck again. |
Also or-tools need C++17 to compile (actually C++20 for msvc due to usage of "agregate initialization" (which is backported to ref: |
I'm aware of the ABI-implications of compiling abseil with C++17. ;-) So since both of those types ( |
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=788588&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=1678 correctly see a |
@h-vetinari please take a look at: EDIT: I can see a re2 tag https://github.com/google/re2/tree/2023-03-01 but no 2023.03.02 |
FYI re2 perform the transition to absl::string_view alias in tag |
Thanks. AFAIR the use of abseil types was already supported before that with an option, but it seems the first step should just be to unblock that re2 upgrade. :) |
…nda-forge-pinning 2023.10.13.01.23.53
@Mizux, with the newer re2, this gets further, but now fails at
should the |
Any ideas what's going on here @Mizux? :) |
@h-vetinari seems to comes from google/or-tools@734df45 https://github.com/google/or-tools/commits/main/ortools/sat/cuts.cc see around August 10th seems we had fought against abseil-cpp/re2 version bump... Also you are using re2 2023-06-02 while v9.7 has been released with 2023-07-01 ps: For incoming v9.8 we will use re2 2023-09-01 (patch on |
@h-vetinari So:
note: in your |
…nda-forge-pinning 2024.02.26.09.48.22
f1b1e29
to
f955ff3
Compare
Sorry for the very long delay here. I finally unblocked newer re2, but by now, abseil has moved on. The lowest we can go is 20230802, though the migration to 20240116 is already in progress. In any case, I'm surprised by the following error.
AFAICT, this should be explicitly covered by abseil/abseil-cpp@34eb767, which is part of 20230802, but it seems that either abseil (or the compiler) don't think that the respective template applies, presumably because PS. The errors for abseil 20240116 looked even worse (at first glance), so I made it possible to use newer re2 with the previous abseil as well. That said, if things don't work for 9.7, we can try 9.8 directly as well of course. |
@h-vetinari FYI we are stabilising or-tools for v9.9 release (hopefully this week) so you may try to bump directly to it. C++
Python
Conda-forge refhttps://github.com/conda-forge/abseil-cpp-feedstock 20240116.1 up to date |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5799934866, please use this URL for debugging.