Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Prepare for Qiskit 1.0 #7

Closed
wants to merge 15 commits into from
Closed

Conversation

wshanks
Copy link
Contributor

@wshanks wshanks commented Jan 3, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@wshanks
Copy link
Contributor Author

wshanks commented Jan 3, 2024

This is just to test in preparation for Qiskit 1.0 which merges the qiskit and qiskit-terra PyPI packages, so the qiskit package will be like what qiskit-terra was before and qiskit-terra will stop getting updates. So this PR mostly copies the recipe from the qiskit-terra feedstock. I don't think we need to merge this as a beta release, but I wanted to start testing. When 1.0.0 is released, we can update the version and SHA here and make this the update PR, or we can close this in favor of a separate update PR.

One thing I realized from making this PR is that we will need to run through the Python 3.12, PyPy, and OSX ARM64 migrations again. I thought about copying those config files from the qiskit-terra feedstock, but I think it is cleaner just to do the migrations again.

@BastianZim
Copy link
Member

One thing I realized from making this PR is that we will need to run through the Python 3.12, PyPy, and OSX ARM64 migrations again. I thought about copying those config files from the qiskit-terra feedstock, but I think it is cleaner just to do the migrations again.

Yes, it‘s probably better to do that. The ARM64 migration needs to be kicked off by adding the name to the config file but I can do that when ready.

@wshanks
Copy link
Contributor Author

wshanks commented Jan 3, 2024

@BastianZim I removed the overlinking error from the config which is how qiskit-terra-feedstock was configured. Is there no better workaround?

After that, we hit an error with symengine. I think this is a new one (in qiskit-terra-feedstock we were always restricted to python-symengine<0.10 qiskit-terra used 0.11 in its last build; maybe the issue is new in 0.11.2 or something else about zstd in the environment changed). I opened conda-forge/python-symengine-feedstock#50 for it.

@BastianZim
Copy link
Member

Is there no better workaround?

It can be a false positive but I would wait until you get some feedback on the issue. I'm not super familiar with over linking so it might make sense to post in the group chat as well.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@wshanks
Copy link
Contributor Author

wshanks commented Feb 16, 2024

Superseded by #12.

@wshanks wshanks closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants