Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt does not link to conda libs (libjpeg, libtiff) #124

Open
jschueller opened this issue Jan 20, 2020 · 9 comments
Open

qt does not link to conda libs (libjpeg, libtiff) #124

jschueller opened this issue Jan 20, 2020 · 9 comments

Comments

@jschueller
Copy link
Contributor

jschueller commented Jan 20, 2020

qt imageformats plugins do not link

  • to libjpeg as qt wants libjpeg-turbo (it checks for jpeg_crop_scanline, needed for chromium 3rd party)
    the bad news is that conda forge wont switch anytime soon:
    Switch to / provide libjpeg-turbo conda-forge.github.io#673
  • to libtiff (depends on libjpeg), worse it links to ImageIO's framework on osx (libTIFF.dylib)
@hmaarrfk
Copy link
Contributor

i don't think we are against moving to turbo, but we are just slow since it seems involved. your help would be greatly apprecaited moving to turbo.

@traversaro
Copy link
Contributor

* to libjpeg as qt wants libjpeg-turbo (it checks for jpeg_crop_scanline, needed for chromium 3rd party)
  the bad news is that conda forge wont switch anytime soon:
  [conda-forge/conda-forge.github.io#673](https://github.com/conda-forge/conda-forge.github.io/issues/673)

Even if conda-forge does not globally switch to jpeg-turbo, I think it can work fine if any port that requires it just depends on jpeg-turbo .

@isuruf
Copy link
Member

isuruf commented Mar 21, 2021

Even if conda-forge does not globally switch to jpeg-turbo, I think it can work fine if any port that requires it just depends on jpeg-turbo .

No. We can either switch to jpeg-turbo or not at all. Nothing in the middle please.

@traversaro
Copy link
Contributor

traversaro commented Mar 21, 2021

Even if conda-forge does not globally switch to jpeg-turbo, I think it can work fine if any port that requires it just depends on jpeg-turbo .

No. We can either switch to jpeg-turbo or not at all. Nothing in the middle please.

Sorry, I meant that I recalled that there are some port already depended on jpeg-turbo, see https://github.com/search?l=YAML&q=org%3Aconda-forge+libjpeg-turbo&type=Code . If this is not support/discouraged, probably it should be documented somewhere?

@isuruf
Copy link
Member

isuruf commented Mar 21, 2021

If this is not support/discouraged

Yes, it is not supported and discouraged.

probably it should be documented somewhere?

We are all volunteers here. PRs to docs are welcome.

@traversaro
Copy link
Contributor

probably it should be documented somewhere?

We are all volunteers here. PRs to docs are welcome.

Sure! I just explained why I had no idea depending on libjpeg-turbo was not supported and discouraged, not complaining that it was not documented anywhere.

@isuruf
Copy link
Member

isuruf commented Mar 21, 2021

libjepg and libjpeg-turbo have common symbols and loading both into the same process can be problematic.
This is the same situation with MKL and openblas where we also discourage having both in the same env.

@hmaarrfk
Copy link
Contributor

I remember one thing that was brought up was that qt isn't easy to build. With the speed at which all the dependencies are released on conda forge, it would be a large maintenance burden to depend on too many things.

@hmaarrfk hmaarrfk transferred this issue from conda-forge/qt-feedstock Feb 20, 2023
@hmaarrfk
Copy link
Contributor

In 2024, we now link to jpeg-turbo but not to libtiff, we can likely address this now that much of the infrastructure has been cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants