Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to C++17; compatible ABI with abseil #62

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

h-vetinari
Copy link
Member

Fixes #61 and establishes compatibility with C++17 abseil

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari changed the title WIP: C++17 Switch to C++17; compatible ABI with abseil Feb 18, 2023
@h-vetinari h-vetinari marked this pull request as ready for review February 18, 2023 12:03
@h-vetinari
Copy link
Member Author

@conda-forge/re2

Unfortunately, re2's ABI depends on the C++ standard used to compile (more specifically, at least on the outcome of #ifdef __cpp_lib_string_view, see #61), and even more unfortunately, the current version is incompatible with the C++17 ABI of abseil.

Since fixing this changes ABI changes, I'm introducing a spurious (but tiny) version bump, which shouldn't be that much of an issue though since the version is YY-MM-DD. This would allows us to cleanly remigrate this package.

PTAL

@h-vetinari
Copy link
Member Author

Gentle ping @conda-forge/re2. This is blocking some feedstocks like or-tools that need to use both abseil & re2, and cannot with the C++17 required for abseil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile with C++17 (compatibility with abseil)
2 participants