-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cuda-nvml-dev recipe #22127
Add cuda-nvml-dev recipe #22127
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cc @jakirkham |
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Update build.sh to align with other components
|
||
test: | ||
commands: | ||
- test -f $PREFIX/targets/{{ target_name }}/lib/stubs/libnvidia-ml.so # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the non-stub library shipped? (Another package?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a driver file, which we have no conda package for
nvidia_driver-linux-x86_64-525.85.12-archive/lib/libnvidia-ml.so.525.85.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Maybe a comment could help explain that? I wasn't aware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the unresolved question about where to ship nvml/example/
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving presuming outstanding issues are resovled.
Once the PR is merged can we open an issue on the feedstock to track the packaging of the examples? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, aside from one small question about sysroot.
test: | ||
commands: | ||
- test -f $PREFIX/targets/{{ target_name }}/lib/stubs/libnvidia-ml.so # [linux] | ||
- test -f $PREFIX/targets/{{ target_name }}/include/nvml.h # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this land in $PREFIX/include
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We held off on putting symlinks in $PREFIX/include
for all packages. IIRC there were concerns with the generic naming of headers, such as math_functions.h
and others. Using nvcc
will include the targets
directory by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I think we should prioritize a strategy around this because most of these are host functions where nvcc
isn't required and generally shouldn't be used if there's no kernels / device code.
Thanks all! 🙏 Let's follow up on anything else in the feedstock 🙂 |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).