Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_constrained to vs activation #75

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 9, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2015_runtime' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

@h-vetinari
Copy link
Member

Seems something changed about how the redistributable exe packages the cab files, at least for x64. We get ERROR: No such file or directory, somewhere in unpack_cab(os.path.join(tmpdir, cabs[0]), cabdir1, env) (if I read the stack trace correctly).

@jdblischak
Copy link
Member

What is the status of this PR? The related PR in the pinning feedstock, conda-forge/conda-forge-pinning-feedstock#5756, was already merged

@isuruf isuruf added the automerge Merge the PR when CI passes label Apr 30, 2024
@github-actions github-actions bot merged commit 6d3a1f2 into conda-forge:main Apr 30, 2024
10 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants