Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to {{ stdlib("c") }} #163

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Switch to {{ stdlib("c") }} #163

merged 4 commits into from
Apr 17, 2024

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Apr 17, 2024 •
edited by jakirkham
Loading

Replaces sysroot* with {{ stdlib("c") }}

Fixes #162

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Apr 17, 2024
Closed
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/8729038555.

@jakirkham
Migrate to {{ stdlib('c') }}
ae13a9f 
Replace `sysroot*` usage with `{{ stdlib('c') }}`. Also set the
`c_stdlib_version` in `conda_build_config.yaml`.
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/8729087410.

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/8729111167.

@jakirkham jakirkham changed the title MNT: rerender Switch to {{ stdlib("c") }} Apr 17, 2024
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Apr 17, 2024
@github-actions github-actions bot merged commit b510f47 into conda-forge:main Apr 17, 2024
16 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldanor aldanor Awaiting requested review from aldanor aldanor is a code owner

@fhoehle fhoehle Awaiting requested review from fhoehle fhoehle is a code owner

@hcho3 hcho3 Awaiting requested review from hcho3 hcho3 is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@ksangeek ksangeek Awaiting requested review from ksangeek ksangeek is a code owner

@mfansler mfansler Awaiting requested review from mfansler mfansler is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to {{ stdlib("c") }}
2 participants
@conda-forge-admin @jakirkham