Rebuild for r-base 4.4 and UCRT mingw toolchain #177

regro-cf-autotick-bot · 2024-07-27T04:06:24Z

This PR has been triggered in an effort to update r-base44_and_m2w64-ucrt.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.}

…nda-forge-pinning 2024.07.26.18.03.15

conda-forge-webservices · 2024-07-27T04:06:32Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jakirkham · 2024-07-27T04:50:13Z

@conda-forge-admin, please re-render

jakirkham · 2024-07-27T04:52:26Z

@conda-forge-admin, please re-render

…nda-forge-pinning 2024.07.26.18.03.15

…d_m2w64-ucrt-0-1_h48cfea

This should get removed by the migrator, but was missed here. So go ahead and remove it manually. regro/cf-scripts@841ebd1#diff-0d312c1a702d1d1c6fc460f9d333907eaeb1f65d08ed61a36603697eec7cd60dR21-R22

jakirkham · 2024-07-31T04:53:14Z

@conda-forge-admin, please re-render

github-actions · 2024-07-31T04:55:32Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10174282202.

jakirkham · 2024-07-31T05:31:56Z

@conda-forge-admin , please re-render

…nda-forge-pinning 2024.07.31.04.56.44

recipe/meta.yaml

jakirkham · 2024-07-31T07:41:58Z

@conda-forge-admin , please re-render

github-actions · 2024-07-31T07:44:20Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10176143912.

h-vetinari · 2024-07-31T08:18:38Z

recipe/meta.yaml

+        - {{ stdlib('m2w64_c') }}      # [win]
+        - {{ compiler('c') }}          # [unix]
+        - {{ compiler('cxx') }}        # [unix]
+        - {{ stdlib('c') }}            # [unix]
        - llvm-openmp                  # [osx]


fails on missing openmp AFAICT

Suggested change

- llvm-openmp # [osx]

- llvm-openmp # [not linux]

So macOS and Linux seem to be doing ok. This already uses LLVM OpenMP on macOS and libgomp

Windows is having issues though. Am debating adding the Fortran compiler to see if that helps with detection

Ah right, nevermind, I see that libgomp gets pulled into that environment already.

All good :)

Appreciate the second set of eyes. Wouldn't be surprised if I'm missing something on the Windows side of things

jakirkham · 2024-07-31T08:18:52Z

Looks like there is an issue finding Windows OpenMP on CI:

CMake Error at D:/bld/xgboost-split_1722411873928/_build_env/Library/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
-- Configuring incomplete, errors occurred!

jakirkham · 2024-07-31T08:28:02Z

@conda-forge-admin , please re-render

github-actions · 2024-07-31T08:30:50Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10176776784.

jakirkham · 2024-07-31T08:35:32Z

@conda-forge-admin , please re-render

…nda-forge-pinning 2024.07.31.04.56.44

…d_m2w64-ucrt-0-1_h48cfea

mfansler · 2024-09-10T09:01:50Z

Thanks for working on this so far! ❤️

I just wanted to send a gentle nudge that it would be nice to see this resolved. Perhaps a motivator: xgboost is currently the heaviest node that the migrator is waiting on to merge.

jakirkham · 2024-09-25T05:33:47Z

Without a Windows machine to debug the remaining errors, this is pretty hard to progress on. If there is someone with an interest in this and a Windows machine available, would encourage them to dive in

jakirkham · 2024-09-25T05:48:48Z

@conda-forge-admin , please re-render

github-actions · 2024-09-25T05:52:50Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

…d_m2w64-ucrt-0-1_h48cfea

jakirkham · 2024-09-25T06:05:50Z

@conda-forge-admin , please re-render

github-actions · 2024-09-25T06:07:04Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

github-actions · 2024-09-25T06:09:50Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/11027261294.

trivialfis · 2024-09-25T06:14:28Z

I think msvc doesn't handle the R C API header very well. It should be a commen issue for all r C extensions though, curious how others are doing.

jakirkham · 2024-09-25T06:37:05Z

Think we are using MinGW for R builds. That said, could very well have configuration issues that need updates in this PR

FWIW here is the current error on CI:

CMake Error at cmake/modules/FindLibR.cmake:48 (message):
  

  dlltool.exe not found!

  Do you have Rtools installed with its MinGW's bin/ in PATH?
Call Stack (most recent call first):
  cmake/modules/FindLibR.cmake:167 (create_rlib_for_msvc)
  R-package/CMakeLists.txt:1 (find_package)

regro-cf-autotick-bot added 2 commits July 27, 2024 04:01

Rebuild for r-base 4.4 and UCRT mingw toolchain

e119024

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.37.1, and co…

fc4f7b7

…nda-forge-pinning 2024.07.26.18.03.15

regro-cf-autotick-bot requested review from aldanor, fhoehle, hcho3, jakirkham, ksangeek, mfansler and xhochy as code owners July 27, 2024 04:06

Readd Windows on R

8dd5658

jakirkham force-pushed the rebuild-r-base44_and_m2w64-ucrt-0-1_h48cfea branch from 9c10351 to 8dd5658 Compare July 27, 2024 04:52

conda-forge-webservices[bot] and others added 4 commits July 27, 2024 04:54

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.37.1, and co…

2cf77d3

…nda-forge-pinning 2024.07.26.18.03.15

Merge conda-forge/main into regro-cf-autotick-bot/rebuild-r-base44_an…

040e4f1

…d_m2w64-ucrt-0-1_h48cfea

Merge conda-forge/main into regro-cf-autotick-bot/rebuild-r-base44_an…

df347ad

…d_m2w64-ucrt-0-1_h48cfea

Drop posix from r-xgboost on Windows

f445a42

This should get removed by the migrator, but was missed here. So go ahead and remove it manually. regro/cf-scripts@841ebd1#diff-0d312c1a702d1d1c6fc460f9d333907eaeb1f65d08ed61a36603697eec7cd60dR21-R22

Add {{ stdlib('m2w64_c') }} on Windows

6571c3e

conda-forge-webservices[bot] and others added 2 commits July 31, 2024 05:34

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.37.1, and co…

41a0a5a

…nda-forge-pinning 2024.07.31.04.56.44

Use m2-bash in r-xgboost Windows build

2ac39ff

h-vetinari reviewed Jul 31, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Just use MinGW-w64 in r-xgboost Windows

663dc93

h-vetinari reviewed Jul 31, 2024

View reviewed changes

Try MinGW Fortran for Windows OpenMP search

4ccf854

Add {{ compiler('m2w64_fortran') }} to top-level

cbef2fe

conda-forge-webservices[bot] and others added 3 commits July 31, 2024 08:38

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.37.1, and co…

c9df956

…nda-forge-pinning 2024.07.31.04.56.44

Slightly reorder top-level requirements

fdf1c7b

Merge conda-forge/main into regro-cf-autotick-bot/rebuild-r-base44_an…

dbef2b8

…d_m2w64-ucrt-0-1_h48cfea

Merge conda-forge/main into regro-cf-autotick-bot/rebuild-r-base44_an…

8603bd7

…d_m2w64-ucrt-0-1_h48cfea

jakirkham force-pushed the rebuild-r-base44_and_m2w64-ucrt-0-1_h48cfea branch from e12a39f to 8603bd7 Compare September 25, 2024 06:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild for r-base 4.4 and UCRT mingw toolchain #177

Rebuild for r-base 4.4 and UCRT mingw toolchain #177

regro-cf-autotick-bot commented Jul 27, 2024

conda-forge-webservices bot commented Jul 27, 2024

jakirkham commented Jul 27, 2024

jakirkham commented Jul 27, 2024

jakirkham commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

jakirkham commented Jul 31, 2024

jakirkham commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

h-vetinari Jul 31, 2024

jakirkham Jul 31, 2024

h-vetinari Jul 31, 2024

jakirkham Jul 31, 2024

jakirkham commented Jul 31, 2024

jakirkham commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

jakirkham commented Jul 31, 2024

mfansler commented Sep 10, 2024

jakirkham commented Sep 25, 2024

jakirkham commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

jakirkham commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

trivialfis commented Sep 25, 2024

jakirkham commented Sep 25, 2024

Rebuild for r-base 4.4 and UCRT mingw toolchain #177

Are you sure you want to change the base?

Rebuild for r-base 4.4 and UCRT mingw toolchain #177

Conversation

regro-cf-autotick-bot commented Jul 27, 2024

conda-forge-webservices bot commented Jul 27, 2024

jakirkham commented Jul 27, 2024

jakirkham commented Jul 27, 2024

jakirkham commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

jakirkham commented Jul 31, 2024

jakirkham commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

h-vetinari Jul 31, 2024

Choose a reason for hiding this comment

jakirkham Jul 31, 2024

Choose a reason for hiding this comment

h-vetinari Jul 31, 2024

Choose a reason for hiding this comment

jakirkham Jul 31, 2024

Choose a reason for hiding this comment

jakirkham commented Jul 31, 2024

jakirkham commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

jakirkham commented Jul 31, 2024

mfansler commented Sep 10, 2024

jakirkham commented Sep 25, 2024

jakirkham commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

jakirkham commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

trivialfis commented Sep 25, 2024

jakirkham commented Sep 25, 2024