support stdlib() jinja function #4999

h-vetinari · 2023-09-10T22:14:30Z

Description

Checklist - did you ...

Add a file to the news directory (using the template) for the next release's release notes?
Add / update necessary tests?
Add / update outdated documentation?

Fixes #4981

Continuation of #4996, as requested.

cc @chenghlee, @mbargull, @beckermr

isuruf · 2023-09-24T01:38:53Z

Let's add a test and get this in.

h-vetinari · 2023-09-24T08:17:35Z

Test added; I tried to copy an existing test for the compiler-jinja. Could someone trigger the tests please?

h-vetinari · 2023-09-24T11:15:09Z

I'm not sure if GHA is having problems or if it's a rights issue, but I cannot inspect any of the failing (or passing) test runs - the logs straight up fail to load (raw logs too). I'll try to have a look again tomorrow.

tests/test_metadata.py

h-vetinari · 2023-09-24T22:27:05Z

Thanks for the fixes, now I can also see the test results. :)

h-vetinari · 2023-09-25T02:41:30Z

Cannot inspect the failing test runs, again... 😑

h-vetinari · 2023-09-27T09:35:54Z

Finally was able to inspect the logs, and all the failures are either flaky or unrelated to this PR.

Could someone take a look perhaps? 🙃
@jezdez @kenodegard @beeankha @dholth

h-vetinari · 2023-09-27T10:07:25Z

Just saw #5013; presumably we're too late to catch that release-train? 😑

jezdez · 2023-09-27T10:21:32Z

@h-vetinari I'm sorry yeah, we're pretty close to the end of the month as is, but I'm sure we'll do a follow-up release! (don't have to wait for 2 months)

Due to the order in which cbc.yaml is parsed.

JeanChristopheMorinPerso · 2023-10-05T13:11:11Z

Should we add docs in this PR or should it be done in a separate PR?

dholth · 2023-10-05T13:31:39Z

It should be the same PR.

h-vetinari

Should we add docs in this PR or should it be done in a separate PR?

It should be the same PR.

Done; I added it to the page describing {{ compiler(<lang>) }}, directly below. Happy to move it elsewhere if that's not the best place.

h-vetinari · 2023-10-06T01:55:57Z

docs/source/resources/compiler-tools.rst

+In principle, this facility would make it possible to also express the
+dependence on separate stdlib implementations (like ``musl`` instead of
+``glibc``), or to remove the need to assume that a C++ compiler always needs to
+add a run-export on the C++ stdlib -- it could then be left up to packages
+themselves whether they need ``{{ compiler('cxx') }}`` or not.


The paragraph is a bit forward-looking in nature. It's not exactly what we need in the first iteration, but possible future uses that are enabled by it. I don't mind deleting it, but thought I'd add it for completeness.

Gah, this should have said "whether they need {{ stdlib('cxx') }} or not." of course.

Callek

Just was reading the docs for this and saw a something to point out

docs/source/resources/compiler-tools.rst

h-vetinari · 2023-10-12T01:21:18Z

Could someone trigger the CI workflow here (and ideally: review the PR)? It would be a pity if this missed another cycle.

jakirkham · 2023-10-18T17:36:22Z

Could someone please let us know what is still needed here?

h-vetinari · 2023-10-25T07:38:12Z

Gentle ping here :)

beckermr · 2023-10-25T14:33:45Z

YOLO don't hate me.

jakirkham · 2023-10-25T17:30:39Z

Thanks all! 🙏

conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 10, 2023

h-vetinari mentioned this pull request Sep 10, 2023

support stdlib() jinja function #4996

Closed

3 tasks

isuruf reviewed Sep 24, 2023

View reviewed changes

tests/test_metadata.py Outdated Show resolved Hide resolved

isuruf force-pushed the stdlib branch from 435778a to 617b0be Compare September 24, 2023 21:35

h-vetinari mentioned this pull request Sep 26, 2023

DISCUSS: Raise MacOS minimum target from 10.9 to 10.13? conda-forge/conda-forge.github.io#1844

Closed

9 tasks

isuruf requested a review from a team October 2, 2023 16:07

isuruf and others added 8 commits October 4, 2023 16:07

support stdlib() jinja function

085caad

Fix typos

a4d8ee8

Fix formatting

4df0454

Fix func signature

04e974e

re-add compiler to jinja_context-namespace

49af1df

add test for stdlib jinja

c3d7e82

Fix tests

d99909d

Need platform and arch as well.

349dc00

Due to the order in which cbc.yaml is parsed.

isuruf force-pushed the stdlib branch from 83d4e81 to 349dc00 Compare October 4, 2023 21:07

add documentation for stdlib jinja-function

35dd69f

h-vetinari commented Oct 6, 2023

View reviewed changes

Callek reviewed Oct 6, 2023

View reviewed changes

docs/source/resources/compiler-tools.rst Outdated Show resolved Hide resolved

h-vetinari force-pushed the stdlib branch from bb6b80a to d2070a1 Compare October 6, 2023 04:26

minor edits after review

ffc32a4

h-vetinari force-pushed the stdlib branch from d2070a1 to ffc32a4 Compare October 6, 2023 04:28

flesh out explanation of how stdlib is intended to work

d4b4d97

JeanChristopheMorinPerso reviewed Oct 6, 2023

View reviewed changes

docs/source/resources/compiler-tools.rst Outdated Show resolved Hide resolved

docs/source/resources/compiler-tools.rst Outdated Show resolved Hide resolved

docs/source/resources/compiler-tools.rst Outdated Show resolved Hide resolved

h-vetinari added 2 commits October 7, 2023 07:43

reST nits

a7423eb

avoid "resp." abbreviation, reformulate sentence & reflow paragraph

9ad1a81

h-vetinari mentioned this pull request Oct 15, 2023

libcxx 17.0.6 conda-forge/libcxx-feedstock#131

Merged

Merge branch 'main' into stdlib

5bbfaf8

jaimergp approved these changes Oct 25, 2023

View reviewed changes

beckermr approved these changes Oct 25, 2023

View reviewed changes

chenghlee approved these changes Oct 25, 2023

View reviewed changes

beckermr merged commit e2916a2 into conda:main Oct 25, 2023
25 checks passed

h-vetinari deleted the stdlib branch October 25, 2023 18:32

This was referenced Oct 25, 2023

implement stdlib Jinja function mamba-org/boa#379

Open

implement stdlib Jinja function prefix-dev/rattler-build#239

Closed

jezdez added this to the 3.28.0 milestone Nov 13, 2023

kenodegard mentioned this pull request Dec 1, 2023

Release 3.28.x #5071

Closed

67 tasks

h-vetinari mentioned this pull request Dec 12, 2023

Reopen the discussion on stdlib jinja function #5053

Closed

h-vetinari mentioned this pull request Feb 17, 2024

ENH: Improve stdlib-handling #5190

Closed

2 tasks

h-vetinari mentioned this pull request Feb 28, 2024

Fix stdlib being recognized in variant hash inputs #5195

Merged

3 tasks

h-vetinari mentioned this pull request Mar 8, 2024

META: {{ stdlib("c") }} migration conda-forge/conda-forge.github.io#2102

Open

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support stdlib() jinja function #4999

support stdlib() jinja function #4999

h-vetinari commented Sep 10, 2023 •

edited

Loading

isuruf commented Sep 24, 2023

h-vetinari commented Sep 24, 2023

h-vetinari commented Sep 24, 2023

h-vetinari commented Sep 24, 2023

h-vetinari commented Sep 25, 2023

h-vetinari commented Sep 27, 2023

h-vetinari commented Sep 27, 2023

jezdez commented Sep 27, 2023

JeanChristopheMorinPerso commented Oct 5, 2023

dholth commented Oct 5, 2023

h-vetinari left a comment

h-vetinari Oct 6, 2023

h-vetinari Oct 6, 2023

Callek left a comment

h-vetinari commented Oct 12, 2023

jakirkham commented Oct 18, 2023

h-vetinari commented Oct 25, 2023

beckermr commented Oct 25, 2023

jakirkham commented Oct 25, 2023

support stdlib() jinja function #4999

support stdlib() jinja function #4999

Conversation

h-vetinari commented Sep 10, 2023 • edited Loading

Description

Checklist - did you ...

isuruf commented Sep 24, 2023

h-vetinari commented Sep 24, 2023

h-vetinari commented Sep 24, 2023

h-vetinari commented Sep 24, 2023

h-vetinari commented Sep 25, 2023

h-vetinari commented Sep 27, 2023

h-vetinari commented Sep 27, 2023

jezdez commented Sep 27, 2023

JeanChristopheMorinPerso commented Oct 5, 2023

dholth commented Oct 5, 2023

h-vetinari left a comment

Choose a reason for hiding this comment

h-vetinari Oct 6, 2023

Choose a reason for hiding this comment

h-vetinari Oct 6, 2023

Choose a reason for hiding this comment

Callek left a comment

Choose a reason for hiding this comment

h-vetinari commented Oct 12, 2023

jakirkham commented Oct 18, 2023

h-vetinari commented Oct 25, 2023

beckermr commented Oct 25, 2023

jakirkham commented Oct 25, 2023

h-vetinari commented Sep 10, 2023 •

edited

Loading