Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to get_conda_operation_locks #5259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tl-hbk
Copy link

@tl-hbk tl-hbk commented Mar 26, 2024

Description

Fixes issue #4215

The function signature was changed a while back

def get_conda_operation_locks(locking=True, bldpkgs_dirs=None, timeout=900):
locks = []
bldpkgs_dirs = ensure_list(bldpkgs_dirs)
# locks enabled by default
if locking:
for folder in (*context.pkgs_dirs[:1], *bldpkgs_dirs):
if not os.path.isdir(folder):
os.makedirs(folder)
lock = get_lock(folder, timeout=timeout)
locks.append(lock)
# lock used to generally indicate a conda operation occurring
locks.append(get_lock("conda-operation", timeout=timeout))
return locks

But this call to it was not updated

locks = utils.get_conda_operation_locks(config)

Example of updated call

locks = utils.get_conda_operation_locks(
locking, bldpkgs_dirs, timeout
)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@tl-hbk tl-hbk requested a review from a team as a code owner March 26, 2024 19:45
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 26, 2024
@tl-hbk tl-hbk force-pushed the fix_get_conda_operation_locks_call branch from 01ef1d6 to 03f702b Compare March 27, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants