td-shim: use static memory for temp stacks of APs #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the use of heap can improve the functional safety. A piece of large enough static memory is allocated to hold the temparary stacks of APs which can support maximum 15 APs. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
jyao1
reviewed
May 27, 2024
| @@ -18,6 +18,8 @@ use crate::asm::{ap_relocated_func_addr, ap_relocated_func_size}; | |||
| // The maximum size of memory used for AP stacks is 30 KB. | |||
| const MAX_WORKING_AP_COUNT: u32 = 15; | |||
jyao1
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of heap can improve the functional safety. A piece of large enough static memory is allocated to hold the temparary stacks of APs which can support maximum 15 APs.
Related issue: #685