td-shim: use fixed-size array for ACPI table installation #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaojiaqi7
force-pushed
the
0524/remove_heap_for_acpi_installation
branch
from
5576869
to
1c44bff
Compare
Replace the vector with a fixed-array to record the table offsets of ACPI tables. The maximum number of ACPI tables is 128 according to Linux Kernel implementation. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
gaojiaqi7
force-pushed
the
0524/remove_heap_for_acpi_installation
branch
from
1c44bff
to
2d2ed06
Compare
jyao1
reviewed
May 27, 2024
| use td_shim_interface::acpi::{calculate_checksum, Rsdp, Xsdt}; | ||
|
|
||
| use super::*; | ||
|
|
||
| #[derive(Default)] | ||
| const ACPI_MAX_TABLES: usize = 128; |
There was a problem hiding this comment.
what if VMM inputs more table number > ACPI_MAX_TABLES?
jyao1
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the vector with a fixed-array to record the table offsets of ACPI tables. The maximum number of ACPI tables is 128 according to Linux Kernel implementation.
Related issue: #685